The patch at #2233507: Error Occurs On Add Form With Differently Named Single Bundle was failing tests, which had nothing to do with the patch.

I fixed the test in one of the two failing test case classes, pushed the fix, and requested a re-test.

The test is still failing, and looking at the failures, seems to be using the version of the module code from before I pushed a fix.

Is there a delay between commits getting pushed to git and the testbot picking them up?

Comments

drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm commented
Project: Drupal.org infrastructure » Drupal.org Testbots
Component: qa.drupal.org » unexplained test failure
rfay’s picture

rfay
Primary language English
Location Palisade, CO, USA
CreditAttribution: rfay commented

The testbot tests the latest code of the current project. However, dependencies don't get updated until new dev releases are built, every 12 hours (after a commit).

Please be much more specific about what code you think is causing the problem, whether it's yours or that of a dependency. And please look on drupalcode.org to make sure that your changed code is there.

joachim’s picture

joachim CreditAttribution: joachim commented

1. The patch at #2233507: Error Occurs On Add Form With Differently Named Single Bundle, on entity_operations module, was reporting 2 failing test cases
2. I didn't think the patch affected either of those test cases at all, so...
3. I ran tests locally on HEAD (ie without the patch)
4. I found that EntityOperationsGenericFormsTestCase was failing locally
5. I made 2 commits to fix the tests: 982077e43fc513a4d106bf9c8812176cf486a21d, 4040d28f25b804db81c714346d86fc384276882a
6. I pushed the changes (these are on drupalcode.org now; obviously I can't check to see if they got there then)
7. I requested a re-test of the patch
8. The patch failed again, with the same failure messages as previously
9. This led me to believe that the testbot was not getting the latest version of the code.

AFAICT I can't see the older test results at https://qa.drupal.org/pifr/test/765298

rfay’s picture

rfay
Primary language English
Location Palisade, CO, USA
CreditAttribution: rfay commented

Please read the FAQ again about differences between your environment and the testbot.

One thing I've done in the past is added in debug() statements in a commit (to be removed later) to verify what's going on on the testbot.

joachim’s picture

joachim CreditAttribution: joachim commented

I'm not sure how the environment makes a difference in this case. This was specific failures in the test as run by the testbot, such as:

> Missing argument 6 for EntityOperationsOperationEditGeneric::entityForm(), called in /var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/entity_operations/includes/entity_operations.operation_handlers.inc on line 1830 and defined

which I had fixed in my commits.

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented

I recently discovered the testbot checks out the version that is specified in the issue, so be sure to always specify the branch in the issue, and never a particular tag. In this case the issue should have been set to 7.x-1.x instead of 7.x-1.4.

joachim’s picture

joachim CreditAttribution: joachim commented
Status: Active » Closed (works as designed)

Ah that makes sense!

It even says on the patch review page 'Branch: Entity Operations - 7.x-1.4'.

Thanks for clearing that up.