I just noticed that there's a mismatch since #2195563: Update _variables.scss for foundation 4.3.2
That updated the SCSS to 4.3.2, but left the Javascript at 4.3.1
I'm not sure how best to approach that and if it causes any issues, but as a safe solution what I'm doing is using Uglify.js to create a new foundation.min.js that aggregates the necessary files, but adding a version to the filename and then calling it specifically in the subtheme's .info file.
I've created a foundation-4.3.2.min.js file that includes everything from the 4.3.2 gem but ever since the Heartbleed attack notice went up, I can't seem to attach files.
You can grab that and then in your subtheme simply load it as
scripts[] = js/foundation-4.3.2.min.js
You could also grab the 4.3.2 files from the gem (or the foundation download) and include only those pieces you want and depend on Drupal's native minification to handle the compression.
If people are interested, I'm happy to provide a patch that just trades this all out.
Comment | File | Size | Author |
---|---|---|---|
#4 | 4.3.2_css_js-2236409-4.patch | 1.94 MB | mrP |
Comments
Comment #1
mrP CreditAttribution: mrP commentedAttached is a (large) patch to update css and js files to foundation-4.3.2
Comment #2
interdruper CreditAttribution: interdruper commentedJust a comment: this update in foundation.min.js from 4.3.1 to 4.3.2 is specially relevant if you deal with the Orbit slider. Some bugs are fixed and additional options are available for the slider in 4.3.2. See Foundation 4.3.2 docs for more info.
You may apply this patch or just replace the js/foundation.min.js file in your sub-theme with the 4.3.2 version extracted from the package downloaded from the Zurb website.
Comment #3
christopheryoder CreditAttribution: christopheryoder commentedThis is my first Drupal.org comment and I'm pretty new to all this, but here goes:
I applied this patch and noticed that the css files in the starter folder still have 4.3.1 in their comments. I believe the css files need to be recompiled.
Comment #4
mrP CreditAttribution: mrP commentedGood point. FWIW, it's pretty silly to be duplicating all these javascript files in the STARTER theme, but for now, here is the full (and even larger) patch.
app.css has been updated based on the compass recompiled custom.css
A complete list of modified files below:
For the record, this also fixes:
js/vendor/custom.modernizr.js
was inadvertently removed.Comment #6
shauntyndall CreditAttribution: shauntyndall commentedGood stuff @mrP. I've review / committed patch #4 to the 4.x-dev branch. Hope to have a new stable release posted soon.