I'm currently running 7.x-2.0-beta2+16-dev with Authcache Panels by Page Manager running. Everything is working fine except on the pages with a panel that is set to use Authcache per user / per page with "Never Cache" set. I am doing this with the Node Links so my flags react instantly when a user "favorites" a node.

When I view any node setup this way as authenticated there are no errors. When I view the node as anonymous user I see the following error:

Notice: Trying to get property of non-object in authcache_panels_panels_pane_content_alter() (line 61 of /var/www/sites/all/modules/authcache/modules/authcache_panels/authcache_panels.module).

When I disable the Authcache caching on the panel in question, flush the cache and view as anonymous user again, the error goes away.

For reference here is the code in the file being called. I have marked what is line 61 where the problem is coming from below.

/**
 * Implements hook_panels_pane_content_alter().
 */
function authcache_panels_panels_pane_content_alter($content, $pane, $args, $context, $renderer, $display) {
  if (authcache_page_is_cacheable() && authcache_panels_pane_fragment_enabled($pane)) {
    $config = _authcache_panels_pane_get_options($pane);

    $fragment = array(
      '#theme' => 'authcache_p13n_fragment',
      '#fragment' => authcache_panels_pane_fragment_id($pane),
      '#clients' => $config['clients'],
      '#fallback' => $config['fallback'],
    );

    $element = array('#markup' => $content->content);     <----- LINE 61
    authcache_p13n_attach($element, $fragment);

    $content->content = render($element);
  }
}
CommentFileSizeAuthor
#5 2237659-prevent-error-when-rendering-empty-pane-5.diff6.28 KBznerol
#5 2237659-TEST-ONLY-prevent-error-when-rendering-empty-pane-5.diff5.12 KBznerol
#4 2237659-prevent-error-when-rendering-empty-pane.diff666 bytesznerol
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Ravenight’s picture

Ravenight CreditAttribution: Ravenight commented
Title: Anonymous user with authcace enabled for a panel are getting - Notice: Trying to get property of non-object in authcache_panels_panels_pane_content_alter() (line 61 of /var/www/sites/all/modules/authcache/modules/authcache_panels/authcache_panels.module). » Anonymous user with authcace enabled for a panel are getting - Notice: Trying to get property of non-object in authcache_panels_panels_pane_content_alter() (line 61 of .. /modules/authcache_panels/authcache_panels.module).
Ravenight’s picture

Ravenight CreditAttribution: Ravenight commented

I added a workaround for this with the following addition to check if the $content variable is available or not.

if (!empty($content)) {
      $element = array('#markup' => $content->content);
      authcache_p13n_attach($element, $fragment);

      $content->content = render($element);
    }

So far everything seems to be okay.

Ravenight’s picture

Ravenight CreditAttribution: Ravenight commented
Title: Anonymous user with authcace enabled for a panel are getting - Notice: Trying to get property of non-object in authcache_panels_panels_pane_content_alter() (line 61 of .. /modules/authcache_panels/authcache_panels.module). » Hidden panels generating error for Anonymous users

Edit title to something shorter

znerol’s picture

znerol CreditAttribution: znerol commented
Status: Active » Needs review
Issue tags: +Needs tests
FileSize
2237659-prevent-error-when-rendering-empty-pane.diff666 bytes

Thank you very much @Ravenight for the detailed report and the proposed solution. I think we should attach the fragment loader even when the content is empty though. Consider the following example:

A panel pane contains a per-user list (e.g. a view) of favorite content (or even line items in a shopping cart).

  1. User A with an empty list accesses the page, results in a cache-miss, the markup (without the loader) is saved
  2. User B already having some items in the list hits the cached page. However because the loader was not attached when the page was generated for User A, User B will not see its items

Therefore I think we should attach the fragment loader even when there is no content.

znerol’s picture

znerol CreditAttribution: znerol commented
FileSize
2237659-TEST-ONLY-prevent-error-when-rendering-empty-pane-5.diff5.12 KB
2237659-prevent-error-when-rendering-empty-pane-5.diff6.28 KB

Ok, just dugg a bit deeper into that problem. Apparently the panels sometimes passes NULL into the $content parameter of hook_panels_pane_content_alter(), especially when a ctools block (e.g. a panels pane) did not return anything. We cannot possibly attach the loader code when $content is NULL, so we also need to cater for that.

Please note:

--- a/modules/authcache_panels_page_manager/authcache_panels_page_manager.test
+++ b/modules/authcache_panels_page_manager/authcache_panels_page_manager.test
@@ -182,4 +182,58 @@ class AuthcachePanelsPageManagerTest extends DrupalWebTestCase {
[...]
+    // Test succeeds if there was no error during the rendering of the page.
+    // However sadly, we are not able to attach the fragment loader when a
+    // content pane did not produce any result. This might result in weird
+    // results like outlined in https://drupal.org/node/2237659#comment-8681127.
+    // Somebody has an idea on how to fix that?
+    //
+    // Correct but failing assertions:
+    // $this->assertText($substituted_markup);
+    // $this->assertStub($fragment_stub, HookStub::once());
+    //
+    // Wrong but working assertions:
+    $this->assertNoText($substituted_markup);
+    $this->assertStub($fragment_stub, HookStub::never());

The last submitted patch, 5: 2237659-TEST-ONLY-prevent-error-when-rendering-empty-pane-5.diff, failed testing.

  • Commit ff48ead on 7.x-2.x by znerol: 
    Issue #2237659 by Ravenight: Prevent errors when rendering empty panel...
znerol’s picture

znerol CreditAttribution: znerol commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.