Problem/Motivation

MigrateSourceJSON::$sourceUrls contain an array of URLs and MigrateSourceJSON::$activeUrl contains the key of the current URL. The first key of MigrateSourceJSON::$sourceUrls is 0. MigrateSourceJSON::activeUrl() is supposed to return the current URL. It first checks to see if MigrateSourceJSON::$activeUrl evaluates to TRUE. Because 0 evaluates to FALSE, the first URL is not returned.

Proposed resolution

Change the test to check whether MigrateSourceJSON::$activeUrl is set.

CommentFileSizeAuthor
#1 first-active-url-2237755.patch762 bytesDarren Oh
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Darren Oh’s picture

Issue summary: View changes
Status: Active » Needs review
FileSize
762 bytes

Added patch.

  • Commit 9990131 on 7.x-2.x authored by Darren Oh, committed by mikeryan:
    Issue #2237755 by Darren Oh: Fix activeUrl handling in JSON source
    
mikeryan’s picture

Status: Needs review » Fixed

Simple and sensible, I like those, thanks!

Darren Oh’s picture

Issue summary: View changes

Thanks! Updated issue summary.

mikeryan’s picture

Issue tags: +Migrate 2.6

Tagging as 2.6.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.