I noticed the field Security Review showing in a few organization nodes in lower left side, but I think the field is blank so it should not be appearing on these nodes.

Examples:
https://drupal.org/node/2237865
https://drupal.org/node/2235403
https://drupal.org/node/2236325

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

drumm’s picture

This needs to be not displayed, or maybe even removed. It is designed to be used for bookkeeping of hosting companies who have had a security review.

tvn’s picture

Title: Security Review field appears on organization node » Titles for empty fields appear on new organization nodes
Status: Active » Postponed (maintainer needs more info)

Security review field is still needed, should not be removed. The problem however is not only with this field, for the pages you listed all empty fields have their titles shown, e.g. 'Usual project budget' and 'Drupal contributions'.
After simply re-saving nodes, titles for empty fields are gone.

All 3 org pages had 0 revisions. Usually people edit their pages at least a few times before they get into the Marketplace. So it is possible that this behavior existed all the time, we just never noticed it. Alternatively this can be something new, after D7 upgrade or recent edit form changes. This needs some more investigation.

drumm’s picture

Status: Postponed (maintainer needs more info) » Active

I can reproduce this on a dev site.

The checks like:

      if ($field_items = field_get_items('node', $node, 'field_organization_security')) {

in drupalorg_node_view() likely need to be improved.

opdavies’s picture

Assigned: Unassigned » opdavies
opdavies’s picture

Status: Active » Needs review
FileSize
2.92 KB

Here's a patch that hides the following fields, if empty:

  • Organization headquarters
  • Budget
  • Security review
  • Contributions

For performance reasons, this only applies when the view mode is "full".

drumm’s picture

Status: Needs review » Fixed
Issue tags: +needs drupal.org deployment
drumm’s picture

Issue tags: -needs drupal.org deployment

Now deployed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.