Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Comment | File | Size | Author |
---|---|---|---|
#10 | drupal8-locale_docs-2238659-10.patch | 11.38 KB | Gábor Hojtsy |
#9 | drupal8-locale_docs-2238659-9.patch | 11.39 KB | Jalandhar |
#7 | interdiff.txt | 3.35 KB | Jalandhar |
#7 | drupal8-locale_docs-2238659-7.patch | 11.39 KB | Jalandhar |
locale_docs.patch | 11.41 KB | chx | |
Comments
Comment #1
Gábor HojtsyLooks good to me :)
Comment #3
Gábor HojtsyThe only change code change is
-use Drupal\Core\Database\Database;
, which I don't see locally either why would be needed. Sending for a retest.Comment #4
Gábor Hojtsylocale_docs.patch queued for re-testing.
Comment #5
Gábor HojtsyComment #6
jhodgdonI don't think this is actually quite ready:
a) The formatting here is a bit off:
- Lists should be preceded by a line like "One of the following values:"
- The last line should be indented 2 more spaces.
b)
This should just say "@return $this" with no description. Several methods below have the same thing.
Comment #7
Jalandhar CreditAttribution: Jalandhar commentedUpdating patch as said in comment 6. Please review.
Comment #8
Gábor HojtsyAlmost :)
Should use : not .
Comment #9
Jalandhar CreditAttribution: Jalandhar commentedOk.
Used ':' instead of '.' and updating patch. updating patch wth this change
Comment #10
Gábor HojtsyAlso updated from "Use one of the..." to "One of the" on the same line, since this is a return value, not an argument. Same was suggested by @jhodgdon above. This is such a minor change and all other changes look good that this is RTBC :)
Comment #11
jhodgdonThanks - also looks good to me. Committed to 8.x.