Drupal 8 has different structure of array with user roles. GA code shows for all roles without reference to settings in admin interface.

CommentFileSizeAuthor
#2 Issue-2238837-Roles-visibility-doesnt-work.patch1.01 KBhass
#1 google_analytics-roles-visibility-bug-2238837-1.patch1.34 KBPlazik
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Plazik’s picture

Plazik CreditAttribution: Plazik commented
Status: Active » Needs review
FileSize
google_analytics-roles-visibility-bug-2238837-1.patch1.34 KB

The path fixed it.

hass’s picture

hass CreditAttribution: hass commented
FileSize
Issue-2238837-Roles-visibility-doesnt-work.patch1.01 KB

Thanks a lot for your patch and the notification. I just reviewed your patch and I may found an easier patch. Please review.

hass’s picture

hass CreditAttribution: hass commented
Parent issue: » #1948588: Google Analytics 8 upgrade
hass’s picture

hass CreditAttribution: hass commented
Status: Needs review » Fixed

  • Commit b25b228 on 8.x-2.x by hass: 
    Issue #2238837: Roles visibility doesn't work

  • Commit 6ace5db on 8.x-2.x by hass: 
    Issue #2238837: Missed variables name in setting.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

The last submitted patch, 1: google_analytics-roles-visibility-bug-2238837-1.patch, failed testing.

Status: Closed (fixed) » Needs work

The last submitted patch, 2: Issue-2238837-Roles-visibility-doesnt-work.patch, failed testing.

hass’s picture

hass CreditAttribution: hass commented
Status: Needs work » Closed (fixed)