The issue over in #2236381: Webform 4 - not updating tokens and conditionals got me thinking that we could do a lot to improve the robustness of our upgrade path. Some of our updates we check if a table or column exists before trying to add/rename to the same thing, but not always. Let's expand this pattern to prevent upgrade problems whenever possible.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

quicksketch’s picture

Status: Active » Fixed
FileSize
2.03 KB

I've committed this simple patch that wraps all our updates that don't already check for existing tables in db_table/column_exists checks.

  • Commit a9dcd1d on 7.x-4.x by quicksketch:
    Issue #2239079: Increase the robustness of our update hooks where...
fenstrat’s picture

Version: 7.x-4.0-beta3 » 8.x-4.x-dev
Assigned: Unassigned » fenstrat
Status: Fixed » Patch (to be ported)

Needs porting to 8.x-4.x.

fenstrat’s picture

Version: 8.x-4.x-dev » 7.x-4.0-beta3
Assigned: fenstrat » Unassigned
Status: Patch (to be ported) » Fixed

Committed and pushed a9dcd1d to 8.x-4.x. Thanks!

  • Commit f1602b1 on 8.x-4.x authored by quicksketch, committed by fenstrat:
    Issue #2239079 by quicksketch: Increase the robustness of our update...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.