Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Viewing tag pages, or the main page with a list of articles results in a page with "0 view this month."
Comment | File | Size | Author |
---|---|---|---|
#8 | wrong_0_views-2241927-8.patch | 847 bytes | ram4nd |
Comments
Comment #1
ram4nd CreditAttribution: ram4nd commentedI have the same problem. UTF-8 characters are urlencoded and it doesn't work. I bet it requires a simple url decode.
Comment #2
ram4nd CreditAttribution: ram4nd commentedComment #3
ram4nd CreditAttribution: ram4nd commentedSame issue seems to apply on the newer branch.
Comment #4
rongok CreditAttribution: rongok commentedI had the same issue. The patch in #2 fixed the issue.
Comment #5
ram4nd CreditAttribution: ram4nd commentedComment #6
grendzy CreditAttribution: grendzy commentedI believe this is fixed in #1345542: pull defaultPage from management API, instead of assuming index.html.
The proposed patch won't work, because it will just break it for people with the default "index.html".
Comment #7
ram4nd CreditAttribution: ram4nd commentedMain fix is the urldecode.
I don't know what you mean by default "index.html".
Comment #8
ram4nd CreditAttribution: ram4nd commentedThis will still be valid.
Comment #9
ram4nd CreditAttribution: ram4nd commentedComment #10
grendzy CreditAttribution: grendzy commentedI will try to clarify... when a pageView is recorded on the home page, Google tracks the URL according to the "defaultPage" setting in your account profile. Early versions of this module had an error and assumed that defaultPage was always "index.html" (which I think is Google's default-default, at least on older accounts).
This patch makes the same error in reverse, by assuming the the defaultPage is always "/". If you "fix" it for one group of users, you will simply break it for the other, which is why the correct solution is in #1345542: pull defaultPage from management API, instead of assuming index.html.
Comment #11
ram4nd CreditAttribution: ram4nd commentedNo I am not talking about front page any more. I am talking about other characters in url, that come in urlencoded shape. For the module to work you need to decode them first for the api.
Comment #12
grendzy CreditAttribution: grendzy commentedI see, that makes sense.
Comment #13
Plazik CreditAttribution: Plazik commentedSame issue for 6.x #1787040: Block does not display page views when url contains utf characters (not transliterated urls ) or the path is the front page (/).
Comment #16
Plazik CreditAttribution: Plazik commented@ram4nd, thanks for patch! Commited to 7.x-1.x and 7.x-3.x.