Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Upon moving the project back to its proper repository, it should strictly follow the Drupal coding standards, especially the documentation standards.
If you want to help, please make sure you are closely familiar with these standards and keep to them! It is also highly recommended to use an IDE with strict warning settings to easily find most problems (and maybe even automate part of the corrections).
The following is an incomplete list of our current coding problems:
- There should be a blank linke between the initial
<?phpand the/**starting the file doc in PHP files (since core also does that in almost all cases). Also, there should be a blank line before the closing}of a class/interface/trait definition. There shouldn't be a blank line following any opening{, except for classes/interfaces/traits. - Order of doxygen tags
- Proper type documentation; Especially: use "bool" and "int", not "boolean" and "integer", for data type docs; use
string[]instead ofarrayif you know its an array of strings (etc.); use@return $this, not@return self. - Always use interfaces, not classes, for type hinting (also in doc comments!).
- Remove unnecessary imports
- Use
elseifinstead ofelse if. - Use
$entity_class::create()instead ofentity_create(). - Variable names should be explanatory for the variable use, and be neither too short (e.g., one letter only in few cases (more or less only in
fororforeachloops)) nor too long (e.g.,$desired_state_setter_method). Also, use$indexnot$entityif you know it's an index (unless you are overriding a method or implementing a hook). And keep consistent: especially, use$datasourceonly for plugin objects and$datasource_idfor the IDs (same for servers, indexes, etc.). Finally, variables should use snake case. - Too complicated code should use inline comments to explain what is going on. (If you don't understand a specific section yourself, just ask me or whoever wrote it.)
At the same time, trivial code should not be documented just stating what happens. (E.g., not each form element needs an "Add form element XY" comment above it.)
Inline comments should also (like all other comments) form complete sentences and end with a period. - Use
\Drupal\search_api\Index\IndexInterface::DATASOURCE_ID_SEPARATORinstead of hardcoding|so we can then easily switch to using.instead. - Pass
$eas the third parameter when wrapping an exception into aSearchApiException. - Not really code style, but still good to fix here: in PHPUnit test cases'
assertEquals()calls, the expected value should come first, then the actual value. Only that way the output in case of a fail is correct. (For Drupal tests, I don't think it matters.) - Remove translation from exception messages – see #2055851: Remove translation of exception messages.
And here is the list of files that need to be looked at. If you want to work on one, please strike through its name and add yours next to it, so we avoid collissions as well as possible.
config/install/search_api.settings.yml– drunken monkeyconfig/schema/search_api.datasource.schema.yml– drunken monkeyconfig/schema/search_api.index.schema.yml– drunken monkeyconfig/schema/search_api.processor.schema.yml– drunken monkeyconfig/schema/search_api.schema.yml– drunken monkeyconfig/schema/search_api.server.schema.yml– drunken monkeycss/search_api.admin.css– drunken monkeyjs/index-active-formatters.js– drunken monkeysearch_api.api.php– drunken monkeysearch_api.drush.inc– drunken monkeysearch_api.info.yml– drunken monkeysearch_api.install– drunken monkeysearch_api.libraries.yml– drunken monkeysearch_api.links.action.yml– drunken monkeysearch_api.links.menu.yml– drunken monkeysearch_api.links.task.yml– drunken monkeysearch_api.module– drunken monkeysearch_api.routing.yml– drunken monkeysearch_api.services.yml– drunken monkeysearch_api.theme.inc– drunken monkeysearch_api.views.inc– drunken monkeysearch_api_db/config/install/search_api_db.settings.yml– drunken monkeysearch_api_db/config/schema/search_api_db.backend.schema.yml– drunken monkeysearch_api_db/config/schema/search_api_db.schema.yml– drunken monkeysearch_api_db/search_api_db.info.yml– drunken monkeysearch_api_db/src/Plugin/SearchApi/Backend/SearchApiDbBackend.php– drunken monkeysearch_api_db/src/Tests/SearchApiDbTest.php– drunken monkeysearch_api_db/tests/modules/search_api_test_db/config/install/field.field.entity_test.body.yml– drunken monkeysearch_api_db/tests/modules/search_api_test_db/config/install/field.field.entity_test.keywords.yml– drunken monkeysearch_api_db/tests/modules/search_api_test_db/config/install/field.instance.entity_test.article.body.yml– drunken monkeysearch_api_db/tests/modules/search_api_test_db/config/install/field.instance.entity_test.article.keywords.yml– drunken monkeysearch_api_db/tests/modules/search_api_test_db/config/install/field.instance.entity_test.item.body.yml– drunken monkeysearch_api_db/tests/modules/search_api_test_db/config/install/field.instance.entity_test.item.keywords.yml– drunken monkeysearch_api_db/tests/modules/search_api_test_db/config/install/search_api.index.database_search_index.yml– drunken monkeysearch_api_db/tests/modules/search_api_test_db/config/install/search_api.server.database_search_server.yml– drunken monkeysearch_api_db/tests/modules/search_api_test_db/search_api_test_db.info.yml– drunken monkeysrc/Annotation/SearchApiBackend.php– drunken monkeysrc/Annotation/SearchApiDatasource.php– drunken monkeysrc/Annotation/SearchApiProcessor.php– drunken monkeysrc/Annotation/SearchApiTracker.php– drunken monkeysrc/Backend/BackendInterface.php– drunken monkeysrc/Backend/BackendPluginBase.php– drunken monkeysrc/Backend/BackendPluginManager.php– drunken monkeysrc/Backend/BackendSpecificInterface.php– drunken monkeysrc/Batch/IndexBatchHelper.php– drunken monkeysrc/Controller/SearchApiIndexController.php– drunken monkeysrc/Controller/SearchApiServerController.php– drunken monkeysrc/Datasource/DatasourceInterface.php– drunken monkeysrc/Datasource/DatasourcePluginBase.php– drunken monkeysrc/Datasource/DatasourcePluginManager.php– drunken monkeysrc/Entity/Index.php– drunken monkeysrc/Entity/Server.php– drunken monkeysrc/Exception/SearchApiException.php– drunken monkeysrc/Form/IndexClearConfirmForm.php– drunken monkeysrc/Form/IndexDeleteConfirmForm.php– drunken monkeysrc/Form/IndexDisableConfirmForm.php– drunken monkeysrc/Form/IndexFieldsForm.php– drunken monkeysrc/Form/IndexFiltersForm.php– drunken monkeysrc/Form/IndexForm.php– drunken monkeysrc/Form/IndexReindexConfirmForm.php– drunken monkeysrc/Form/IndexStatusForm.php– drunken monkeysrc/Form/ServerClearConfirmForm.php– drunken monkeysrc/Form/ServerDeleteConfirmForm.php– drunken monkeysrc/Form/ServerDisableConfirmForm.php– drunken monkeysrc/Form/ServerForm.php– drunken monkeysrc/Form/ServerStatusForm.php– drunken monkeysrc/Index/IndexInterface.php– drunken monkeysrc/IndexListBuilder.php– drunken monkeysrc/Item/AdditionalFieldInterface.php– drunken monkeysrc/Item/AdditionalField.php– drunken monkeysrc/Item/FieldInterface.php– drunken monkeysrc/Item/Field.php– drunken monkeysrc/Item/FieldTrait.php– drunken monkeysrc/Item/GenericFieldInterface.php– drunken monkeysrc/Item/ItemInterface.php– drunken monkeysrc/Item/Item.php– drunken monkeysrc/Plugin/ConfigurablePluginBase.php– drunken monkeysrc/Plugin/ConfigurablePluginInterface.php– drunken monkeysrc/Plugin/IndexPluginBase.php– drunken monkeysrc/Plugin/IndexPluginInterface.php– drunken monkeysrc/Plugin/SearchApi/Datasource/ContentEntityDatasource.php– drunken monkeysrc/Plugin/SearchApi/Datasource/ContentEntityDatasourceDeriver.php– drunken monkeysrc/Plugin/SearchApi/Processor/AddURL.php– drunken monkeysrc/Plugin/SearchApi/Processor/AggregatedField.php– drunken monkeysrc/Plugin/SearchApi/Processor/ContentAccess.php– drunken monkeysrc/Plugin/SearchApi/Processor/Highlight.php– drunken monkeysrc/Plugin/SearchApi/Processor/HtmlFilter.php– drunken monkeysrc/Plugin/SearchApi/Processor/IgnoreCase.php– drunken monkeysrc/Plugin/SearchApi/Processor/IgnoreCharacter.php– drunken monkeysrc/Plugin/SearchApi/Processor/Language.php– drunken monkeysrc/Plugin/SearchApi/Processor/NodeStatus.php– drunken monkeysrc/Plugin/SearchApi/Processor/RenderedItem.php– drunken monkeysrc/Plugin/SearchApi/Processor/Resources/Cc.php– drunken monkeysrc/Plugin/SearchApi/Processor/Resources/Cf.php– drunken monkeysrc/Plugin/SearchApi/Processor/Resources/Co.php– drunken monkeysrc/Plugin/SearchApi/Processor/Resources/Mc.php– drunken monkeysrc/Plugin/SearchApi/Processor/Resources/Me.php– drunken monkeysrc/Plugin/SearchApi/Processor/Resources/Mn.php– drunken monkeysrc/Plugin/SearchApi/Processor/Resources/Pc.php– drunken monkeysrc/Plugin/SearchApi/Processor/Resources/Pd.php– drunken monkeysrc/Plugin/SearchApi/Processor/Resources/Pe.php– drunken monkeysrc/Plugin/SearchApi/Processor/Resources/Pf.php– drunken monkeysrc/Plugin/SearchApi/Processor/Resources/Pi.php– drunken monkeysrc/Plugin/SearchApi/Processor/Resources/Po.php– drunken monkeysrc/Plugin/SearchApi/Processor/Resources/Ps.php– drunken monkeysrc/Plugin/SearchApi/Processor/Resources/Sc.php– drunken monkeysrc/Plugin/SearchApi/Processor/Resources/Sk.php– drunken monkeysrc/Plugin/SearchApi/Processor/Resources/Sm.php– drunken monkeysrc/Plugin/SearchApi/Processor/Resources/So.php– drunken monkeysrc/Plugin/SearchApi/Processor/Resources/UnicodeListInterface.php– drunken monkeysrc/Plugin/SearchApi/Processor/Resources/Zl.php– drunken monkeysrc/Plugin/SearchApi/Processor/Resources/Zp.php– drunken monkeysrc/Plugin/SearchApi/Processor/Resources/Zs.php– drunken monkeysrc/Plugin/SearchApi/Processor/RoleFilter.php– drunken monkeysrc/Plugin/SearchApi/Processor/Stopwords.php– drunken monkeysrc/Plugin/SearchApi/Processor/Tokenizer.php– drunken monkeysrc/Plugin/SearchApi/Processor/Transliteration.php– drunken monkeysrc/Plugin/SearchApi/Tracker/DefaultTracker.php– drunken monkeysrc/Plugin/views/argument/SearchApiArgument.php– drunken monkeysrc/Plugin/views/argument/SearchApiDate.php– drunken monkeysrc/Plugin/views/argument/SearchApiFulltext.php– drunken monkeysrc/Plugin/views/argument/SearchApiMoreLikeThis.php– drunken monkeysrc/Plugin/views/argument/SearchApiString.php– drunken monkeysrc/Plugin/views/argument/SearchApiTaxonomyTerm.php– drunken monkeysrc/Plugin/views/cache/SearchApiCache.php– drunken monkeysrc/Plugin/views/display/FacetsBlock.php– drunken monkeysrc/Plugin/views/field/SearchApiExcerpt.php– drunken monkeysrc/Plugin/views/filter/SearchApiFilter.php– drunken monkeysrc/Plugin/views/filter/SearchApiFilterBoolean.php– drunken monkeysrc/Plugin/views/filter/SearchApiFilterDate.php– drunken monkeysrc/Plugin/views/filter/SearchApiFilterEntityBase.php– drunken monkeysrc/Plugin/views/filter/SearchApiFilterOptions.php– drunken monkeysrc/Plugin/views/filter/SearchApiFilterText.php– drunken monkeysrc/Plugin/views/filter/SearchApiFulltext.php– drunken monkeysrc/Plugin/views/filter/SearchApiLanguage.php– drunken monkeysrc/Plugin/views/filter/SearchApiTerm.php– drunken monkeysrc/Plugin/views/filter/SearchApiUser.php– drunken monkeysrc/Plugin/views/query/SearchApiQuery.php– drunken monkeysrc/Plugin/views/row/SearchApiRow.php– drunken monkeysrc/Plugin/views/sort/SearchApiSort.php– drunken monkeysrc/Processor/FieldsProcessorPluginBase.php– drunken monkeysrc/Processor/ProcessorInterface.php– drunken monkeysrc/Processor/ProcessorPluginBase.php– drunken monkeysrc/Processor/ProcessorPluginManager.php– drunken monkeysrc/Query/Filter.php– drunken monkeysrc/Query/FilterInterface.php– drunken monkeysrc/Query/Query.php– drunken monkeysrc/Query/QueryInterface.php– drunken monkeysrc/Query/ResultSet.php– drunken monkeysrc/Query/ResultSetInterface.php– drunken monkeysrc/Server/ServerInterface.php– drunken monkeysrc/Session/SearchApiUserSession.php– drunken monkeysrc/Task/ServerTaskManager.php– drunken monkeysrc/Task/ServerTaskManagerInterface.php– drunken monkeysrc/Tests/ExampleContentTrait.php– drunken monkeysrc/Tests/IndexStorageUnitTest.php– drunken monkeysrc/Tests/IntegrationTest.php– drunken monkeysrc/Tests/LanguageIntegrationUnitTest.php– drunken monkeysrc/Tests/LocalActionsWebTest.php– drunken monkeysrc/Tests/OverviewPageTest.php– drunken monkeysrc/Tests/Processor/ContentAccessTest.php– drunken monkeysrc/Tests/Processor/ProcessorTestBase.php– drunken monkeysrc/Tests/Processor/RenderedItemTest.php– drunken monkeysrc/Tests/Processor/TestItemsTrait.php– drunken monkeysrc/Tests/SearchApiServerTaskUnitTest.php– drunken monkeysrc/Tests/SearchApiWebTestBase.php– drunken monkeysrc/Tests/ServerStorageUnitTest.php– drunken monkeysrc/Tests/ViewsTest.php– drunken monkeysrc/Tracker/TrackerInterface.php– drunken monkeysrc/Tracker/TrackerPluginBase.php– drunken monkeysrc/Tracker/TrackerPluginManager.php– drunken monkeysrc/Utility/Utility.php– drunken monkeytests/modules/search_api_test_backend/search_api_test_backend.info.yml– drunken monkeytests/modules/search_api_test_backend/search_api_test_backend.module– drunken monkeytests/modules/search_api_test_backend/src/Plugin/SearchApi/Backend/TestBackend.php– drunken monkeytests/modules/search_api_test_views/config/install/views.view.search_api_test_views_fulltext.yml– drunken monkeytests/modules/search_api_test_views/search_api_test_views.info.yml– drunken monkeytests/src/Menu/LocalActionsTest.php– drunken monkeytests/src/Menu/LocalTasksTest.php– drunken monkeytests/src/Plugin/Processor/AddURLTest.php– drunken monkeytests/src/Plugin/Processor/AggregatedFieldTest.php– drunken monkeytests/src/Plugin/Processor/FieldsProcessorPluginBaseTest.php– drunken monkeytests/src/Plugin/Processor/HighlightTest.php– drunken monkeytests/src/Plugin/Processor/HtmlFilterTest.php– drunken monkeytests/src/Plugin/Processor/IgnoreCaseTest.php– drunken monkeytests/src/Plugin/Processor/IgnoreCharacterTest.php– drunken monkeytests/src/Plugin/Processor/LanguageTest.php– drunken monkeytests/src/Plugin/Processor/NodeStatusTest.php– drunken monkeytests/src/Plugin/Processor/ProcessorTestTrait.php– drunken monkeytests/src/Plugin/Processor/RoleFilterTest.php– drunken monkeytests/src/Plugin/Processor/StopwordsTest.php– drunken monkeytests/src/Plugin/Processor/TestFieldsProcessorPlugin.php– drunken monkeytests/src/Plugin/Processor/TokenizerTest.php– drunken monkeytests/src/Plugin/Processor/TransliterationTest.php– drunken monkeytests/src/TestComplexDataInterface.php– drunken monkeytests/src/TestContentEntityInterface.php– drunken monkeytests/src/TestNodeInterface.php– drunken monkeytests/src/TestUserInterface.php– drunken monkey
For YAML files, we probably only need to ensure that everything is properly documented. And, specifically for services.yml, that the services are in alphabetical order.
Original report by drunken monkey:
Currently, due to about 15 different people having worked on it (with little supervision/review of changes), the adherence to Drupal's coding standards varies wildly throughout the project. Some parts are more or less OK, some need a lot of work in that regard.
I have always tried to keep as closely as possible to the coding standards and would like to take the chance with the new version to start from a "clean slate", with a module completely adhering to them. (The D7 version currently doesn't fulfill this due to various changes to the standards themselves.) A complete clean-up of the module in this regard is therefore definitely something that needs to happen before (or, rather, when) I transfer this sandbox back to the canonic Search API project.
(While doing this, we should also make sure that all hooks we are defining are properly documented, and that all documented hooks are really still used (in that form).)
When that time comes, I'd of course be glad about any help I can get. (This is also something that can be very well split up, because you can just check and clean up a file completely separately from the others.)
But until then, everyone can also already help by checking up on the latest version of the standards and (even more important, since more often overlooked) the documentation standards and keeping to them as closely as possible when working on the module.
Cleaning the code up now is probably not a good idea, though, since it might cause too many conflicts. Therefore, please also refrain from making code cleanup changes in unrelated parts of the code (except whitespace, which is hard to control in most editors and can be really annoying).
Also, here's a link to the current PAReview of the sandbox, to show the kinds of errors we have at the moment. Ideally, this would be more or less empty when moving the code back to the Search API project.
Comments
Comment #1
Nick_vhGoing to spend 15 minutes on this now
Comment #2
Nick_vhChanged all line endings to linux format and added a README.txt file.
Fixed:
And
Comment #3
drunken monkeyOne very commonly overlooked rule, e.g., is this:
The same goes for files, classes and interfaces.
@ Nick: How do you want to spend that time? As said, I think it would lead to too many conflicts if we start a large clean up action at this point. Better later, and properly organized (with everyone who wants to help marking the files they'll work on), so people will know to expect it.
Comment #4
Nick_vhMy time's up :) And I reported what I've done
Comment #5
drunken monkeyThat was nothing to fix, that was just PAReview using an old PHP version. That was why I said the list should be "more or less empty" – there are just a few false positives in there.
Comment #6
Nick_vhWell, it's not really a good practice to use a value from an array in an object directly. Unless you know for sure the value will be there of course. Anyway, feel free to revert that one change, that was a really minor thing.
Comment #7
drunken monkeyAnother thing we could do, while we're at it, is sorting the methods in classes to reflect the order of methods in the interface. I think this would help make things a bit clearer.
Comment #8
BerdirWe discussed today that it would be nice to add phpcs to travis, see http://dazz.github.io/2013/07/14/add-phpmd-and-phpcs-to-environments/ for example, you'd also need to add the Drupal coding standard from the coder_sniffer module.
Comment #9
drunken monkeyWhat about the PAReview script, might be an idea, too?
The problem in both cases, though, would probably be that we'd get such a ton of errors at the moment that it would be more or less useless. You'd have to manually check if your commit increased or decreased the amount of warnings …
But I guess it could still be useful.
Comment #10
Nick_vhhttps://travis-ci.org/nickveenhof/search-api-sandbox/jobs/23193019 is a run with php codesniffer. The test won't report it failed but you can always check the output of codesniffer in those builds. It's indeed more informative. How would one run the PAReview script and what would it add next to the codesniffer default?
Comment #11
drunken monkeyHow it's run is explained here, it's very simple. But I guess there's little additional value, compared to the codesniffer. It would probably suffice to run this when we get to the "move back to Search API project" step.
Comment #12
Nick_vhI'm not sure if pareview is already adjusted to the Drupal 8 modules? If it is, it doesn't hurt to run it. Agreeing here that that can wait.
Looking at it, it looks way more complete than just codesniffer. Perhaps we can simulate it using the clean methods such as adding https://drupal.org/project/drupalpractice to the codesniffer templates and running that also.
Comment #13
drunken monkeyWhile doing this, we should also make sure that all hooks we are defining are properly documented, and that all documented hooks are really still used (in that form).
Comment #18
drunken monkeyJust browsed a bit through core issues and created two for this module that we might want to implement also during the "back to its home repository" move:
#2268809: Use short array syntax in module
#2268823: Use t() methods instead of global function
Comments welcome. ;)
Comment #19
drunken monkeyAlso, preparing the OP for organizing the work once we start it. (Please don't start yet, there's still a few issues to solve first.)
Comment #20
drunken monkeyComment #21
drunken monkeyAdded: Pass
$eas the third parameter when wrapping an exception into aSearchApiException.Comment #22
drunken monkeyAdded note about inline comments.
Comment #23
drunken monkeyInline comments should also (like all other comments) form complete sentences and end with a period.
Comment #24
drunken monkeyAlways use interfaces, not classes, for type hinting (also in doc comments!).
Comment #31
drunken monkeyAdded a few more hints for type documentation.
Comment #34
drunken monkeyWhat do you all think about #2055851: Remove translation of exception messages? Should we also not translate our error messages? Core right now is a huge mess in that respect – so maybe we should just wait for a decision there?
In my opinion, not translating exception messages makes a lot of sense – the most compelling reason being that untranslated error messages are much easier to google. But probably waiting for a decision in core makes most sense (if it's realisitic there'll be one, which I hope).
Comment #35
drunken monkeyNot really code style, but still good to fix here: in PHPUnit test cases'
assertEquals()calls, the expected value should come first, then the actual value. Only that way the output in case of a fail is correct. (For Drupal tests, I don't think it matters.)Comment #36
amateescu CreditAttribution: amateescu commentedRe #34: I'm huge +1 on not translating them :)
Comment #43
drunken monkeyAccording to Bram and Andrei, we should use
$entity_class::create()instead ofentity_create(), to get proper code completion/type hinting.Comment #53
drunken monkeyWe agreed on opening this up now, so feel free to start cracking! ;)
Just please mark the files you're working on.
Comment #54
drunken monkeyUpdated file name
ContentEntityDatasourceDeriver.phpaccording to #2297921: Cannot access create index page after D8 core commit 41576e1.Comment #56
drunken monkeyUpdated the list of files – all other blockers for the move back to the "home" repository are now gone, we can finally properly start here.
Comment #57
drunken monkeyWorking on the following files now:
Comment #58
drunken monkeySince I spotted some bugs in the following files, I'm gonna clean those up, too:
It would probably be helpful if people working on other issues could also mark their files here (and later either put them back in or do a cleanup on them), so there are no/less conflicts.
Comment #59
drunken monkeyAny opinions on the naming convention for unit test data providers? Core just has a complete laissez-faire attitude there, with (out of 599):
get*()provider*()(in 149 cases followed by the capitalized name of the test method)*Provider()(including 8 *get*Provider())provide*()From those, I personally like (2) best, since it already contains the complete name of the test method and thereby eliminates any unclarities. On the other hand, of course, starting a method name with a noun is really ugly (even though it (shockingly, I find) doesn't seem to violate the coding standards).
Any thoughts?
Also, should test methods (at least in unit tests) contain the tested method in their names, or just describe what is tested (e.g.,
testProcessFieldValueWithoutCjk()vs.testPreprocessingWithoutCjk())?Comment #60
drunken monkeyWorking on the following files now:
Comment #61
Nick_vhIf number 2 is what you like most I think we should go for that one. I don't feel strongly either way. The one thing that could be confusing if we use number two is that there is likely to be a dataset that can be used for multiple unit tests? So then having the function name in the provider isn't good.
Test methods should just describe what exactly is tested. That said, I do like the example: "testProcessFieldValueWithoutCjk". It leaves less room for improvisation and thus enhances the clarity of the complete test suite.
Comment #62
drunken monkeyHm, they are actually working on a standard in #2057905: [policy, no patch] Discuss the standards for phpunit based tests, so maybe we can just wait for that.
They don't seem to specify in more detail how test methods should be named, though.
Done with the first two batches, but didn't form the commit message like normally, so this issue wouldn't be (even more) flooded.
Working on the following files now:
Comment #63
drunken monkeyWorking on the following files now:
Comment #65
drunken monkeyAfter the interruption caused by #2225353: Convert $form_state to an object and provide methods like setError(), I'm working on the following files now:
Comment #67
drunken monkey(Yes, typo in commit message, it was of course the fifth batch already.)
Working on the following files now:
Comment #69
drunken monkeyWorking on the following files now:
Comment #71
drunken monkeyWorking on the following files now:
Let's see, maybe this will be complete before Amsterdam.
Comment #73
drunken monkeyClaiming all processors and the datasource plugin (with its deriver).
Comment #76
drunken monkeyClaiming the rest of
src/Plugin/.Comment #78
drunken monkeyClaiming
src/Processor/andsrc/Query/.Comment #80
drunken monkeyClaiming the rest of
src/(tests/remaining).Comment #82
drunken monkeyClaiming
tests/, except fortests/src/Plugin.Comment #83
drunken monkeyOK, that was a bit little. Anyways, claiming the rest.
Finally, almost done …
Comment #84
drunken monkey