Goto filter/tips/RK=0/RS=PQfEszymxUq4uTd2Ip.yf4GQ8.Q- for example and we get a number of notices.

Notice: Trying to get property of non-object in _filter_tips() (line 1068 of /home/mingram/public_html/examiner/modules/filter/filter.module).
Notice: Trying to get property of non-object in _filter_tips() (line 1069 of /home/mingram/public_html/examiner/modules/filter/filter.module).

Note this does not affect d8 as filter formats are now entities and 404 nicely!

CommentFileSizeAuthor
filter-format-notice.patch517 bytesmarcingy
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

marcingy’s picture

marcingy CreditAttribution: marcingy commented
Issue summary: View changes
marcingy’s picture

marcingy CreditAttribution: marcingy commented
Status: Active » Needs review
slashrsm’s picture

slashrsm CreditAttribution: slashrsm commented
Status: Needs review » Reviewed & tested by the community

Simple thing and it looks good.

David_Rothstein’s picture

David_Rothstein CreditAttribution: David_Rothstein commented
Status: Reviewed & tested by the community » Needs review

So why not make things 404 nicely in Drupal 7 also? Seems to me like the offending menu callback - filter_tips_long() - is the place to fix this.

Or if you really want to take the position that _filter_tips() itself should be protecting against programmer error in the calling function, then that would need to go in Drupal 8 too since the same code is there...