All the menu system changes after #2226903: Step 1: Move static menu links to yml files, #1316692: Convert hook_admin_paths() into declarative properties on routes and #2085243: Rename Menu module into Menu UI module

CommentFileSizeAuthor
#4 Fix-for-Menu-Links-Default-2244523.patch1.72 KBmanuelbg
devel-menu-changes.patch9.83 KBjibran
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community

Perfect!

pcambra’s picture

pcambra
he/him
Primary language Spanish
Location Asturies
CreditAttribution: pcambra commented
Category: Bug report » Task
Priority: Major » Normal
Status: Reviewed & tested by the community » Needs work

Thanks for the patch and the review, but seems that when I apply it, the links of the menus are gone:

http://monosnap.com/image/OIN4IIPAQmJr8RFnosdJte77Y0bdIs

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented

I also noticed that this seems to duplicate menu links when you do menu link rebuilds, I have 20+ Generate Content links now ;)

manuelbg’s picture

manuelbg CreditAttribution: manuelbg commented
FileSize
Fix-for-Menu-Links-Default-2244523.patch1.72 KB

Following the Change Records of Drupal 8, i found a fix for this issue: hook_menu_link_defaults() moved to *.menu_links.yml files.

manuelbg’s picture

manuelbg CreditAttribution: manuelbg commented
Status: Needs work » Needs review

Can someone review the last patch?

Thanks.

pcambra’s picture

pcambra
he/him
Primary language Spanish
Location Asturies
CreditAttribution: pcambra commented
Status: Needs review » Needs work

Last patch is not taking devel generate into account

juampynr’s picture

juampynr CreditAttribution: juampynr commented
Status: Needs work » Postponed

The patch sent by @jibran is OK but the issue of menu links being duplicated is currently in core. More details can be found at #2258299: dblog_menu_link_defaults_alter() must set 'machine_name' to avoid duplicates.

Setting this issue on hold until the above gets solved.

  • Commit 22a129c on 8.x-1.x authored by jibran, committed by juampy: 
    Issue #2244523 by manuelbg, jibran: Fix devel after all the menu system...
juampynr’s picture

juampynr CreditAttribution: juampynr commented
Status: Postponed » Fixed

Committed. Thanks everyone!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

The last submitted patch, devel-menu-changes.patch, failed testing.

Status: Closed (fixed) » Needs work

The last submitted patch, 4: Fix-for-Menu-Links-Default-2244523.patch, failed testing.

pcambra’s picture

pcambra
he/him
Primary language Spanish
Location Asturies
CreditAttribution: pcambra commented
Status: Needs work » Closed (fixed)