Let's create an example module, which will help developers to start using Plupload integration.

CommentFileSizeAuthor
#3 plupload_example_module_behaviour_like_d7_branch-2245945-4.patch2.65 KBbudalokko
#1 plupload_example_module_behaviour_like_d7_branch-2245945-2.patch2.66 KBbudalokko
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

budalokko’s picture

budalokko CreditAttribution: budalokko as a volunteer commented
Status: Active » Needs review
FileSize
plupload_example_module_behaviour_like_d7_branch-2245945-2.patch2.66 KB

Attached patch replicates PlUpload test included in 7.x-1.x branch of the module with the exception that it doesn't create yet a record in file_managed_table.

This could be added when Create helper function that will save uploaded files to file_managed table issue is worked on.

I think it could be useful to add something like this to widget settings to give faster guidance to people but didn't add in the patch to keep in sync with 7.x:

'#plupload_settings' => array(
  'max_file_size' => '100mb',
  'chunk_size' => '4mb',
),
slashrsm’s picture

slashrsm CreditAttribution: slashrsm at Examiner.com commented
Status: Needs review » Needs work

There is some trailing whitespace that should be removed. Other than that patch looks OK. Thank you!

budalokko’s picture

budalokko CreditAttribution: budalokko as a volunteer commented
FileSize
plupload_example_module_behaviour_like_d7_branch-2245945-4.patch2.65 KB

Ouch. Attached patch has a better code style.

budalokko’s picture

budalokko CreditAttribution: budalokko as a volunteer commented
Status: Needs work » Needs review
slashrsm’s picture

slashrsm CreditAttribution: slashrsm at Examiner.com commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

  • budalokko committed 861c753 on 8.x-1.x 
    Issue #2245945 by budalokko: Create plupload_example module
budalokko’s picture

budalokko CreditAttribution: budalokko as a volunteer commented

Shouldn't we separate the example in a different module on the 7.x branch too?

budalokko’s picture

budalokko CreditAttribution: budalokko as a volunteer commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.