Adding a inline template for content translation status

Add theme function. Hope right understand issue )

Buratino42, thank you for your work, but your patch from #2 not exactly doing what requested in this issue and require a rework. You just wrapped the hardcoded code in a wrapper function, while we need to create and use a theme function.
Please rework your patch in this way:
* implement a theme using hook_theme
* replace hardcoded $status contents by drupal_render call
* please place in your theme function all status message markup, not only the marker.

Follow links may help you:
https://api.drupal.org/api/drupal/core%21modules%21system%21theme.api.ph...
https://api.drupal.org/api/drupal/core%21modules%21system%21system.api.p...
https://api.drupal.org/api/drupal/core%21includes%21common.inc/function/...

Updating in preparation for DrupalCon Austin sprints. See http://www.hook42.com/blog/prepping-drupalcon-austin-sprints-sprint-lead....

Here is an attempt at a switching it over to hook_theme. It works, but I'm not sure if adding the hooks to the .module file is the commonly accepted approach. I'm still getting used to d8.

We tested against the latest dev version of Drupal 8 and confirmed that the theme hook worked correctly. Tested content translation module and made sure that the outdated string appeared correctly.

Do we really need to a theme function for this? Why would someone override this?

Also, let's not introduce new theme functions when our twig team is so hard at work converting them :-)

I think @joelpittet would be one of the best people to ask about how this type of thing could fit in to the D8 "markup ecosystem" (I've left him a tell on IRC), but yes it would be nice to not introduce new theme functions. Thanks for the ping @alexpott :)

And yes thank you @tstoeckler, we have done a ton of work around #1757550: [Meta] Convert core theme functions to Twig templates so this would just be adding to that list.

In general IMO it's nice to be able to override markup, thinking of admin themes for this case. But it seems weird to introduce a theme function or template for this, it's so specific (we're trying to get rid of as many of these one-offs as possible when it makes sense) and there really isn't much markup. Hoping there is a better way. It may be significant that this is a "marker", I wonder if mark.html.twig could be a fit for at least part of this or if we could make mark__translation_status or something along those lines.

This is really annoying bug, how it looks is #2251907: Wrong status on Translate tab for entities

how it looks now

markup

Code looks great and I manually tested it, works great. Thank you @andypost! I don't think all the issues fixing double escaping need tests added. RTBC from me.

The test would be added in #2251907: Wrong status on Translate tab for entities

I am confused, #2305799: HTML tags (raw) shown in Status column on Translations page was marked as duplicate of #2317557: renderInline not compatible with twig_auto_reload which now contains that as well.

+++ b/core/modules/content_translation/src/Controller/ContentTranslationController.php
@@ -136,9 +136,14 @@ public function overview(Request $request, $entity_type_id = NULL) {
+            '#context' => array(
+              'status' => !empty($translation['status']) ? $this->t('Published') : $this->t('Not published'),
+              'outdated' => !empty($translation['outdated']) ? $this->t('outdated') : '',
+            ),

we can also put all t() calls into the twig itself.

I did mention that the t stuff could be in Twig in IRC, I'm not sure if that's equivalent to $this->t() or if it matters.

@dawehner There's no difference between trans and $this->t() both are parsed fine
My preference is t() because it much clear for translators (users of l.d.o) to get context from code not the templates

@andypost
Sure, both are fine, though it feels just better to move this kind of stuff into templates as they don't really belong to the logic on the code.

@dawehner - as you wish ;) template is a bit longer... and less readable

Thank you!

Looks good.

Committed and pushed to 8.x. Thanks!