Overridden config entity bleeds through to admin forms

There is in fact LocaleAdminPathConfigEntityConverter, which is supposed to solve this but:

- language overrides have since been moved to the language module instead of locale, so this is misplaced
- other kinds of overrides still apply if you don't have language/locale modules enabled we'd still need a generic solution

So I agree a generic solution is needed, but that should remove / adapt the converter already in core instead of adding yet one more way :)

+++ b/core/core.services.yml
@@ -411,6 +411,11 @@ services:
+    tags:
+      - { name: paramconverter, priority: 5 }

It would be great to document why we need a higher priority.

Great, thank you!

Wait a minute, this does indeed solve this in a more general way now for admin forms, but not for admin listings. If @tim.plunkett was to mark #2136559: Config entity admin lists show configuration with overrides (eg. localized) as a duplicate, then this needs to solve the listings too, no?

Right, that is about entity *listings* on the admin interface. Titling this back to the simpler case it is then :) I think it means then that #2136559: Config entity admin lists show configuration with overrides (eg. localized) is also critical.

Making sure Alex gets a chance to look at this before it goes in.

Looks good a couple of minor nits.

1. +++ b/core/modules/config/lib/Drupal/config/Tests/ConfigEntityFormOverrideTest.php
   @@ -0,0 +1,71 @@
   +/**
   + * Tests that config overrides do not bleed through in entity forms.
   + */
   ...
   +      'description' => 'Tests that config overrides do not bleed through in entity forms.',
   

   bleed through? How about "Test that config overrides do not (appear on|effect) entity forms."

2. +++ b/core/modules/config/lib/Drupal/config/Tests/ConfigEntityFormOverrideTest.php
   @@ -0,0 +1,71 @@
   +    // Test that everything on the form is the same, but that the override
   +    // worked for the actual site name.
   

   site name?

Committed 4ad6fc9 and pushed to 8.x. Thanks!

diff --git a/core/modules/config/tests/config_test/lib/Drupal/config_test/ConfigTestController.php b/core/modules/config/tests/config_test/lib/Drupal/config_test/ConfigTestController.php
index c561366..fa7618c 100644
--- a/core/modules/config/tests/config_test/lib/Drupal/config_test/ConfigTestController.php
+++ b/core/modules/config/tests/config_test/lib/Drupal/config_test/ConfigTestController.php
@@ -21,10 +21,10 @@ class ConfigTestController extends ControllerBase {
    * Route title callback.
    *
    * @param \Drupal\config_test\Entity\ConfigTest $config_test
-   *   The ConfigTest object to edit.
+   *   The ConfigTest object.
    *
-   * @return array
-   *   A form array as expected by drupal_render().
+   * @return string
+   *   The title for the ConfigTest edit form.
    */
   public function editTitle(ConfigTest $config_test) {
     return $this->t('Edit %label', array('%label' => $config_test->label()));

Fixed up function docblock

Yay, its great to see again a more generalised solution for what we made up for languages only :) Tagging with D8MI too.