Update Table Trash to work with DataTables library v1.10

Yes, I haven't tried the module with DataTable 1.10 yet.
Stick to 1.9.4

Ouch... you are right. They've done a major overhaul at https://datatables.net/download/index and the old version is not readily available.
I will have to update the Table Trash module....

For now I'm attaching the old version as I use it on my laptop.

Check if you have any browser errors.
If so try switching off features one by one to isolate the one that is causing everything to break.
There may be interference with other things on page. Try switching theme to see if that has anything to do with it.

@monaw: and this demo page works fine for you? http://flink.com.au/tips-tricks/table-trash-demo-page

Same versions on the demo page, I think.
Looks like the Table Trash library is a little temperamental, at least version 1.9.4. But I haven't had time to look into 1.10 yet.
Sorry. This is very frustrating for you.
Have you tried switching to a plain theme, one of the core themes?

No, those should work.
I don't understand what is going on...
Sorry.

Issue title for addressing the original report. Maybe add a separate issue for #6/#8 if it remains a problem?

I had the same problem with the new library. Downloading the version attached here worked like a charm! I did see a 1_9 tag on github: https://github.com/DataTables/DataTables/tree/1_9

seans

@seans and everybody....

Did you not see this at the very top of the project page:

Note: the current DataTables library is 1.10 while this module is based on 1.9.4. The correct library is loaded automatically when you use drush to install the module (see drush commands below). If you wish to install the module manually, you can obtain the DataTables 1.9.4 files from this issue: https://drupal.org/node/2259283#comment-8748515

Thanks @seans for the link though!

I just did a quick and dirty rewrite of the module to get it working with DataTables 1.10.9. A summary of what's I've done.

• Removed the bug fixed variant and all the messy code to get it to work.
• Cleaned up the variable names so they more closely resemble what they actually control
• Put in a very simple upgrade path for anybody with current table trash decorations.
• Moved all of the datatables object creation logic that was in table_trash.js and put it in table_trash_pass_datatables_selectors_and_config(). It's entirely possible that this removed functionality without me realizing it.
• Updated the drush function so that it downloads the appropriate version and extensions.
• Removed all the nondrupaly -'s and replaced them with _'s
• Re-implemented most of the functionality from the current version. I didn't do much updating to the interface though so somethings may not actually work as described.
• Put in todo's where functionality could be expanded.

drush dl-datatables
This should work to download the new DataTables and all of the required extensions.

I didn't do a very thorough testing of all the functionality but what I did test seems to be working more or less how it should. I'm sure with some more eyes on it more bugs will be found.

Spent some more time working on this over the past few days. Besides the one exception at the bottom I'm fairly confident that everything is working as it should. I took some liberties and moved the module away from using a variable to store config and instead started using ctools exportables which means this patch is probably more worthy of a 7.x-2.x release than a continuation 7.x-1.x. A summary of the changes I've made since the last patch:

CHANGES

• Added CTools as a dependency.
• Decorations are no longer stored in a variable. They are now stored in the table_trash table as ctools exportable objects(https://www.drupal.org/node/928026).
• Changed the interface to use the default ctools exportables interface.
• All processing of configuration is now done when a decoration is saved instead of when the decoration is added to a table.
• Added support for scrollY,scrollCollapse,Fixed footer, Fixed right columns, and choosing which export buttons to show.
• Removed the x width feature, as far as I can tell it is no longer supported.
• Updated the decoration form so that it used appropriate field types and descriptions.
• Cleaned up the update path for existing decorations.
• Moved global settings to their own page.
• Made minor changes to the readme.
• And any of other misc stuff that I have forgotten.

Possible ToDos

• Implement a hook to attach custom js to decorations so that Datatables plugins can be used with minimal hassle.
• Implement a hook to allow the Datatables configuration array to be changed before it is parsed to JSON so that any additional Datatables configuration needed can be added.
• Implement decoration weighting so that tables that have more then one decoration applied to them behave in a controllable way.
• Style and organize the decoration form.
• Add support for column visibility and length change.
• Support more than 2 breakpoints?

BROKEN THINGS

• The Datatables css is currently always included because it is in the library.

To update existing decorations it should be as simple as going to admin/config/content/table_trash/update_config, filling in Human and machine names, and clicking the save button. Deleting the variable is totally optional.

A cleaner version of the previous patch that doesn't remove the libraries and includes a couple minor fixes like removing leftover dpms.

Yep happy with it. Go ahead and commit. I've given you the privileges.
Thanks for this solid job!
Rik

Just committed this.

Yay!
Thanks so much ctrlADel