Problem/Motivation

Currently \Drupal\Core\Config\StorageInterface::read() returns FALSE when the configuration object does not exist.

Proposed resolution

Loading entities return NULL when the entity does not exist. Change \Drupal\Core\Config\StorageInterface::read() to match.

Remaining tasks

Write patch and fix tests

User interface changes

None

API changes

Change return type of \Drupal\Core\Config\StorageInterface::read()

CommentFileSizeAuthor
#14 storage-interface-return-null-2260961-14.patch7.96 KBnico.pinos
#12 storage-interface-return-null-2260961-12.patch6.6 KBnico.pinos
#10 storage-interface-return-null-2260961-10.patch4.97 KBnico.pinos
#6 storage-interface-return-null-2260961-6.patch2.99 KBnico.pinos
#4 storage_interface_return_null-2260961-4.patch735 bytesnico.pinos
#2 2260961-2-storageinterface-return-false.patch2.25 KBmtift
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Related issues: +#2224887: Language configuration overrides should have their own storage

This came up in #2224887: Language configuration overrides should have their own storage

mtift’s picture

mtift
he/him
Primary language English
Location Minnesota, USA
CreditAttribution: mtift commented
Status: Active » Needs review
FileSize
2260961-2-storageinterface-return-false.patch2.25 KB

So like this?

Status: Needs review » Needs work

The last submitted patch, 2: 2260961-2-storageinterface-return-false.patch, failed testing.

nico.pinos’s picture

nico.pinos CreditAttribution: nico.pinos commented
Version: 8.x-dev » 8.0-alpha12
Assigned: Unassigned » nico.pinos
Status: Needs work » Needs review
FileSize
storage_interface_return_null-2260961-4.patch735 bytes

I think CachedStorage is decoupled from this.
Something like this would be enough?

Status: Needs review » Needs work

The last submitted patch, 4: storage_interface_return_null-2260961-4.patch, failed testing.

nico.pinos’s picture

nico.pinos CreditAttribution: nico.pinos commented
Version: 8.0-alpha12 » 8.0.x-dev
Status: Needs work » Needs review
FileSize
storage-interface-return-null-2260961-6.patch2.99 KB

Status: Needs review » Needs work

The last submitted patch, 6: storage-interface-return-null-2260961-6.patch, failed testing.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented 
+++ b/core/lib/Drupal/Core/Config/StorageInterface.php
@@ -37,9 +37,9 @@ public function exists($name);
-   * @return array|bool
+   * @return array
    *   The configuration data stored for the configuration object name. If no
-   *   configuration data exists for the given name, FALSE is returned.
+   *   configuration data exists for the given name, NULL is returned.

That would be array|null then?

nico.pinos’s picture

nico.pinos CreditAttribution: nico.pinos commented

Yes, that's an easy fix. I'm getting some errors during the tests though. I'm working on some updates.

nico.pinos’s picture

nico.pinos CreditAttribution: nico.pinos commented
Status: Needs work » Needs review
FileSize
storage-interface-return-null-2260961-10.patch4.97 KB

Updating tests.

Status: Needs review » Needs work

The last submitted patch, 10: storage-interface-return-null-2260961-10.patch, failed testing.

nico.pinos’s picture

nico.pinos CreditAttribution: nico.pinos commented
Status: Needs work » Needs review
FileSize
storage-interface-return-null-2260961-12.patch6.6 KB

Status: Needs review » Needs work

The last submitted patch, 12: storage-interface-return-null-2260961-12.patch, failed testing.

nico.pinos’s picture

nico.pinos CreditAttribution: nico.pinos commented
Status: Needs work » Needs review
FileSize
storage-interface-return-null-2260961-14.patch7.96 KB

Status: Needs review » Needs work

The last submitted patch, 14: storage-interface-return-null-2260961-14.patch, failed testing.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Version: 8.0.x-dev » 8.1.x-dev
Assigned: nico.pinos » alexpott

Is this still valid?

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.0-beta1 was released on March 2, 2016, which means new developments and disruptive changes should now be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Assigned: alexpott » Unassigned
Issue tags: +Needs change record

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.