Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
Entity displays depend on the bundle entity if there is one. If there is not they should depend on the provider of the entity type so they are removed when that module is uninstalled.
Proposed resolution
Fix Drupal\entity\EntityDisplayBase::calculateDependencies to add the dependency.
Remaining tasks
- Write patch
- Review
User interface changes
None
API changes
Additional dependencies in entity displays.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 2261677.3-interdiff.txt | 522 bytes | Berdir |
| #3 | 2261677.3.patch | 3.76 KB | Berdir |
| #2 | 2261677.2.patch | 3.79 KB | alexpott |
| #2 | 1-2-interdiff.txt | 894 bytes | alexpott |
| #1 | 2261677.1.patch | 2.39 KB | alexpott |
Comments
Comment #1
alexpottNot the trickiest thing to fix :)
Comment #2
alexpottForgot to update the default configuration in standard profile. This shows why I missed this - because user is a required module and therefore I didn't notice
entity.view_display.user.user.defaultwas missing an obvious dependency on the user module but aggregator provides an entity type without a bundle entity type so that's why I noticed whilst looking at #2261425: Streamline aggregator's entities rendering with rest of coreComment #3
BerdirLooks good, verified that all default form and view displays have correct dependencies. Just fixed a missing newline at the end of one of those files.
Comment #4
catchCommitted/pushed to 8.x, thanks!