Problem/Motivation
Noticed in #2212427-21: Use interface instead of class name for language manager where appropriate.:
Some things should be typehinted with ConfigurableLanguageManagerInterface not LanguageManagerInterface because they depend on functionality in the ConfigurableLanguageManager that comes with the language module.
Proposed resolution
typehint with ConfigurableLanguageManagerInterface (not LanguageManagerInterface) in ... ?
Remaining tasks
- Identify which should be ConfigurableLanguageManagerInterface not LanguageManagerInterface
- git instructions for creating patch | Contributor task documentation for creating a patch
User interface changes
No.
API changes
Yes.
Comments
Comment #1
YesCT CreditAttribution: YesCT commentedis this a bug?
does this mean we are missing tests?
---
Here was @alexpott's comment from #2212427-21: Use interface instead of class name for language manager where appropriate.:
ConfigurableLanguageManagerInterface? i think all of these depend on functionality in the ConfigurableLanguageManager that comes with the language module.
Comment #2
sunOnly classes in Locale + Language module can depend on
ConfigurableLanguageManager
, because it only exists when Language module is enabled.Any other code can only depend on the non-configurable
LanguageManager
.