Yesterday I did not know this module existed and I made https://github.com/stevector/twig_entity_embed

It also implements the ability to "embed" an entity with the variables entity_type, view_mode and entity_id. Except it does so for Twig. Would you be amenable to a pull request that merges the functionality for Twig into this module?

Comments

stevector’s picture

stevector
he/him
CreditAttribution: stevector commented

I just spoke with Dave Reid in person at Drupalcon and he liked the idea. He encouraged me to to use code from https://github.com/drupal-media/entity_embed/pull/21 I will do so.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer commented

Would still like to push for this in Entity Embed. Maybe I'll take a stab at updating @stevector's code this weekend.

slashrsm’s picture

slashrsm CreditAttribution: slashrsm commented
Issue tags: +Media Initiative, +sprint, +Novice
slashrsm’s picture

slashrsm CreditAttribution: slashrsm commented
Issue tags: -sprint +D8Media
cs_shadow’s picture

cs_shadow CreditAttribution: cs_shadow commented

Working on this on: https://github.com/drupal-media/entity_embed/pull/166

cs_shadow’s picture

cs_shadow CreditAttribution: cs_shadow commented
Status: Active » Needs review
Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer commented
Status: Needs review » Fixed

Rebased and merged.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.