Follow-up to #2287039: Decide if we still want to translate log channel names and make modifications accordingly

Problem/Motivation

watchdog() should accept untranslated string as message

Proposed resolution

Remove remaining message translation.

Remaining tasks

Review. Commit.

User interface changes

no

API changes

None.

CommentFileSizeAuthor
#5 drupal-logger_t-2287063-5.patch1.77 KBParisLiakos
watchdog.patch1.68 KBandypost
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Quick fix

Yay, looks good. Thanks!

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented

watchdog.patch queued for re-testing.

EDIT seems fixed in #2272467: Remove usages of watchdog() from procedural code

Status: Reviewed & tested by the community » Needs work

The last submitted patch, watchdog.patch, failed testing.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Status: Needs work » Closed (duplicate)
Parent issue: » #2272467: Remove usages of watchdog() from procedural code
ParisLiakos’s picture

ParisLiakos CreditAttribution: ParisLiakos commented
Status: Closed (duplicate) » Needs review
FileSize
drupal-logger_t-2287063-5.patch1.77 KB

hmm the t() calls are still there, so, here is the updated patch

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Status: Needs review » Reviewed & tested by the community

So back to rtbc

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

  • webchick committed 880deb2 on 8.x 
    Issue #2287063 by ParisLiakos, andypost: Fixed Remove remains of t() in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.