Over in #2277945: Typed configuration implements TypedDataInterface improperly we changed TypedConfig to work with DataDefinition objects which means we can use it's methods in ElementInterface::getFormElement() implementations.

CommentFileSizeAuthor
#1 2291721.1.patch2.53 KBalexpott
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Active » Needs review
FileSize
2291721.1.patch2.53 KB
Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Issue tags: +D8MI, +language-config

Are there other $definition['s in the config code we can get rid of? :)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented

I had a look couldn't get anywhere else that the new DataDefinition objects methods can/should be used.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Needs review » Reviewed & tested by the community

Good with me then :)

Jose Reyero’s picture

Jose Reyero CreditAttribution: Jose Reyero commented

Related if not the same (at a different level)
#2225961: Introduce "controlled" setters on FieldDefinitionInterface to avoid special-casing FieldDefinition

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

  • catch committed fce26fe on 8.x 
    Issue #2291721 by alexpott: Use methods instead of array access in when...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.