Admin configuration page (at /admin/config) css has 2 visible issues. One is the missing padding between configuration block columns. The other is in the error message; the red thick border at the left must move to the right.

Before patch

Before patch

After patch

After patch

CommentFileSizeAuthor
#6 rtl-padding-after.png22.45 KBchrisbloomfield
#6 rtl-padding-before.png23.41 KBchrisbloomfield
#4 admin-rtl-fix-2309671-4.patch478 bytesherom
admin_config-rtl-fix.patch924 bytesherom
admin-config-rtl-after-cropped.png33.55 KBherom
admin-config-rtl-before-cropped.png33.43 KBherom
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

herom’s picture

herom CreditAttribution: herom commented
Issue summary: View changes
herom’s picture

herom CreditAttribution: herom commented
Issue summary: View changes
Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Needs review » Needs work

There are RTL fixes to messages on #2213583: Misaligned Icons in Drupal 8.x and similar issues. The icon should also be moved to the right, no? I think it would be better to somehow figure out which issue is best to fix the message style.

The page column padding sounds like for this issue definitely.

herom’s picture

herom CreditAttribution: herom commented
Status: Needs work » Needs review
FileSize
admin-rtl-fix-2309671-4.patch478 bytes

Yes, it doesn't belong to this issue. Moved the message styling out.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +D8MI, +language-base

Yay, thanks!

chrisbloomfield’s picture

chrisbloomfield CreditAttribution: chrisbloomfield commented
FileSize
rtl-padding-before.png23.41 KB
rtl-padding-after.png22.45 KB

Patch works as intended & installs cleanly:

Before patch:

After patch:

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Good catch. Committed and pushed to 8.x. Thanks!

  • webchick committed 6db8d05 on 8.0.x 
    Issue #2309671 by herom: Fixed admin configuration page RTL CSS.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.