Problem/Motivation

When reviewing #1912608: Update pagination markup for new CSS standards and improved accessibility with an old settings.php (with twig_debug set to TRUE) it was discovered that Twig trans block debug information is still hooked up to Settings rather than the Twig environment.

Proposed resolution

Fix it!

Remaining tasks

  • Patch
  • Tests likely need to be updated

User interface changes

n/a

API changes

n/a

CommentFileSizeAuthor
#8 interdiff.txt1.11 KBstar-szr
#8 2332989-8.patch1.72 KBstar-szr
#8 2332989-8-test-changes-only.patch1.11 KBstar-szr
#4 2332989-4.patch622 bytesstar-szr
#3 2332989-3.patch674 bytesstar-szr
#1 2332989-1.patch609 bytesstar-szr
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

star-szr’s picture

star-szr
he/him
Primary language English
CreditAttribution: star-szr commented
Status: Active » Needs review
FileSize
2332989-1.patch609 bytes

This is the line that needs to change at least.

star-szr’s picture

star-szr
he/him
Primary language English
CreditAttribution: star-szr commented

Okay it might not be that easy, env is protected…

star-szr’s picture

star-szr
he/him
Primary language English
CreditAttribution: star-szr commented
FileSize
2332989-3.patch674 bytes

Okay, this one I actually tested manually, should work :)

star-szr’s picture

star-szr
he/him
Primary language English
CreditAttribution: star-szr commented
FileSize
2332989-4.patch622 bytes

Can I just start this issue over? :)

The last submitted patch, 1: 2332989-1.patch, failed testing.

The last submitted patch, 3: 2332989-3.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 4: 2332989-4.patch, failed testing.

star-szr’s picture

star-szr
he/him
Primary language English
CreditAttribution: star-szr commented
Assigned: star-szr » Unassigned
Status: Needs work » Needs review
FileSize
2332989-8-test-changes-only.patch1.11 KB
2332989-8.patch1.72 KB
interdiff.txt1.11 KB

Here are the test changes only, test changes + fix, and interdiff.

Edit: and yeah, test-changes-only == interdiff.

The last submitted patch, 8: 2332989-8-test-changes-only.patch, failed testing.

Fabianx’s picture

Fabianx CreditAttribution: Fabianx commented
Status: Needs review » Reviewed & tested by the community

RTBC, looks great

star-szr’s picture

star-szr
he/him
Primary language English
CreditAttribution: star-szr commented
Issue summary: View changes

Thanks @Fabianx!

Fabianx’s picture

Fabianx CreditAttribution: Fabianx commented
Issue tags: +Quickfix
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 078f09a and pushed to 8.0.x. Thanks!

  • alexpott committed 078f09a on 8.0.x 
    Issue #2332989 by Cottser: Fixed Twig trans tag debug is still hooked up...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.