Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Hi.
For starters: thanks for this very handy module - it solves one specific problem in a very precise way, so it's a great little addition. It's also great to have a D7 port, but I've got a few problems with them that I'd like to help solve.
Problems:
1. commenting without approval permissions don't seem to be taken into account.
2. I'm seeing quite some leftover D6 code like an obsolete hook and permission names that have changed between D6 and D7 but haven't been corrected in this code.
3. Some bad/missing formatting/commenting/tabulation
4. out-of-date readme.txt (as noted in other issues)
I've fixed the code for my purposes, but before I contribute it back it needs some further testing of all use cases and I'd like to discuss the rationale for some of the existing code with the maintainer.
@maintainer: how would you like me to contribute? 1 patch with all changes? Create an issue per 'problem' with accompanying patch?
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | comment_perm-comment_wo_approval_not_working-2337963-2-D7.patch | 1.98 KB | lmeurs |
Comments
Comment #1
Plazik CreditAttribution: Plazik commentedI think it should be a several patches.
Comment #2
lmeurs CreditAttribution: lmeurs commentedPatch applied.
Comment #3
pietrocap CreditAttribution: pietrocap commentedPatch #2 works fine for me even when applied to latest dev.
I suggest to commit the patch. I think a lot of people use this module to give commenting without approval permissions to users. This was my case. Anyway thank you for the module!
Comment #4
sja1 CreditAttribution: sja1 commentedWe're using this patch in production and it's working fine.
Comment #5
sja1 CreditAttribution: sja1 commentedComment #7
sdstyles CreditAttribution: sdstyles at FFW commentedFixed in 7.x-2.x branch.
Thanks!