Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
The installer removes English language during installation, if English as interface language during translation. Its not possible for install profile to ship with english as enabled language.
Proposed resolution
Add a new key to the installation profile info file.
Remaining tasks
User interface changes
API changes
| Comment | File | Size | Author |
|---|---|---|---|
| #17 | interdiff.txt | 852 bytes | mauzeh |
| #14 | keep-english-installer-2345969-14.patch | 3.1 KB | mauzeh |
| #14 | keep-english-installer-2345969-14-SHOULD-FAIL.patch | 2.7 KB | mauzeh |
| #13 | keep-english-installer-2345969-13.patch | 3.11 KB | webflo |
Comments
Comment #1
webflo CreditAttribution: webflo commentedThis patch depends on #2336743: When more than one language is added in the profile, the installer ignores those.
Comment #2
webflo CreditAttribution: webflo commentedComment #4
Désiré CreditAttribution: Désiré commentedThe most parts of this patch is already committed, can you submit a new one with the actual changes?
Comment #5
webflo CreditAttribution: webflo commentedRerolled and fixed the failing test.
Comment #7
webflo CreditAttribution: webflo commentedI forgot to include
testing_multilingual.info.ymlin the previous patch.Comment #8
webflo CreditAttribution: webflo commentedComment #9
webflo CreditAttribution: webflo commentedComment #12
webflo CreditAttribution: webflo commentedComment #13
webflo CreditAttribution: webflo commentedRe-rolled after #2336743: When more than one language is added in the profile, the installer ignores those got in.
Comment #14
mauzeh CreditAttribution: mauzeh commented* Added failing test.
* Small change to inline doc.
* Tested this in the GUI.
* Coding standard looks good.
This is something we should document, for instance at https://www.drupal.org/node/2210443 ("How to Write a Drupal 8 Installation Profile"). Will keep an eye on this issue and update the page when it is committed.
Comment #16
LendudeRechecked with @mauzeh, looks good.
Comment #17
mauzeh CreditAttribution: mauzeh commentedWhoops forgot the interdiff.
Comment #22
garphy CreditAttribution: garphy commentedTested it by adding keep_english in standard profile and it worked as it should.
I installed Drupal in French, and English was still there at the end.
I think it can be RTBC. Testbot is not happy because of the SHOULD-FAIL patch but the real patch is green.
Comment #25
webflo CreditAttribution: webflo commentedBack to RTBC. The patch in #14 is green and war already RTBCed in #16
Comment #26
alexpottCommitted 44ad6d7 and pushed to 8.0.x. Thanks!
Comment #28
Gábor HojtsySuperb, thanks!