Problem/Motivation

Documentation in default.services.yml file is out-of-date. For example it mentions twig_auto_reload setting when it should be auto_reload.

Proposed resolution

Check the documentation and update it according to new settings structure.

CommentFileSizeAuthor
#7 update-configuration-names-on-service-yml-2346245-6.patch2.54 KBDavid Hernández
#4 update-configuration-names-on-service-yml-2346245-4.patch1.94 KBDavid Hernández
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

@rteijeiro
Are you sure you look at the proper services.yml file? The default.services.yml file looks fine.

rteijeiro’s picture

rteijeiro CreditAttribution: rteijeiro commented
Title: Update services.yml file documentation » Update default.services.yml file documentation
Issue summary: View changes

@dawehner I mean the following comments:

 9     #  check rendered HTML to fail. When running automated tests, 'twig_debug'
14     #  changes (see twig_auto_reload below).
25     # If you don't provide a value for twig_auto_reload, it will be determined
26     # based on the value of twig_debug.
36     # twig_auto_reload setting above should be enabled rather than disabling the
David Hernández’s picture

David Hernández CreditAttribution: David Hernández commented
Assigned: Unassigned » David Hernández
Issue tags: +Amsterdam2014

Working on this.

David Hernández’s picture

David Hernández CreditAttribution: David Hernández commented
Assigned: David Hernández » Unassigned
Status: Active » Needs review
FileSize
update-configuration-names-on-service-yml-2346245-4.patch1.94 KB

I think that's it.

rteijeiro’s picture

rteijeiro CreditAttribution: rteijeiro commented
Status: Needs review » Needs work

A few nitpicks, sorry :)

  1. +++ b/sites/default/default.services.yml
@@ -6,12 +6,12 @@ parameters:
+    #  check rendered HTML to fail. When running automated tests, 'debug'

    Could you fix indentation here, please? I seems it needs one blank space more. 

  2. +++ b/sites/default/default.services.yml
@@ -6,12 +6,12 @@ parameters:
+    #  changes (see auto_reload below).

    The same here.

The last submitted patch, 4: update-configuration-names-on-service-yml-2346245-4.patch, failed testing.

David Hernández’s picture

David Hernández CreditAttribution: David Hernández commented
Status: Needs work » Needs review
FileSize
update-configuration-names-on-service-yml-2346245-6.patch2.54 KB

This should do it.

rteijeiro’s picture

rteijeiro CreditAttribution: rteijeiro commented
Status: Needs review » Reviewed & tested by the community

It seems good for me.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed c76fb28 and pushed to 8.0.x. Thanks!

  • alexpott committed c76fb28 on 8.0.x 
    Issue #2346245 by David Hernández | rteijeiro: Update default.services....

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.