Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
(First, verify that the preprocess changes have been made. #2322163: [meta] Consensus Banana Phase 1, move CSS classes from preprocess to twig templates.)
- Copy the Twig templates from the core module's templates directory to Classy's templates directory. Include all templates, even ones without classes.
- Remove all classes from the core module's template. Remove all classes added with addClass and ones that are hard-coded in the template.
- If there are classes that are required for basic functionality, discuss whether they should be kept.
- If there is CSS from the module, or anywhere else, referring to the class, discuss removing it or moving it to Bartik&Seven. Do not move the CSS to Classy.
Twig Templates to Copy
core/modules/aggregator/templates/aggregator-block-item.html.twig
core/modules/aggregator/templates/aggregator-feed.html.twig
core/modules/aggregator/templates/aggregator-item.html.twig
Comment | File | Size | Author |
---|---|---|---|
#12 | copy_aggregator-2349615-12.patch | 2.11 KB | mortendk |
#10 | copy_aggregator-2349615-10.patch | 2.18 KB | mortendk |
#8 | copy_aggregator-2349615-8.patch | 2.18 KB | mortendk |
#4 | classy-aggregator.diff | 2.12 KB | mortendk |
Comments
Comment #1
davidhernandezComment #2
davidhernandezComment #3
davidhernandezComment #4
mortendk CreditAttribution: mortendk commentedmoved the classes out of core
Discussion of the classes - should be done as a follow up, so bikesheedding wont stop classy ;)
Comment #5
mortendk CreditAttribution: mortendk commentedComment #6
mortendk CreditAttribution: mortendk commentedComment #8
mortendk CreditAttribution: mortendk commentedmoved the files into classy/templates
Comment #9
davidhernandezThese templates have been moved to classy/templates/aggregator not classy/templates/
Comment #10
mortendk CreditAttribution: mortendk commented*doh* now the templates are moved to /classy/templates/aggregator/
Comment #11
davidhernandezWhat I meant was the templates should be in classy/templates, not classy/templates/aggregator.
Comment #12
mortendk CreditAttribution: mortendk commentedmoved templates into /templates - no subfolders
Comment #13
mortendk CreditAttribution: mortendk commentedComment #14
danquah CreditAttribution: danquah commentedComment #15
danquah CreditAttribution: danquah commentedConfirmed, 3 templates ended up in core/themes/classy/templates/ all classes have been stripped from core/modules/aggregator/templates/aggregator-*
Comment #16
danquah CreditAttribution: danquah commentedComment #17
davidhernandezI'm universally setting all the phase 2 issues back to needs review, because we're missing some things. Please double-check if any removed classes are being used in javascript. It is best to test the affected template using Stark to make sure nothing is broken.
Comment #18
mortendk CreditAttribution: mortendk commentedaggregator dont have any classes thats used by css - setting it back to rtbc (if i can do that ?)
Comment #19
alexpottI can confirm that the classes are not used in css or js.
Committed 1fea878 and pushed to 8.0.x. Thanks!
Comment #20
alexpottThis normal task was committed due the fact the banana consensus received per approval wrt to #2350615: [policy, no patch] What changes can be accepted during the Drupal 8 beta phase?