Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.(First, verify that the preprocess changes have been made. #2322163: [meta] Consensus Banana Phase 1, move CSS classes from preprocess to twig templates.)
- Copy the Twig templates from the core module's templates directory to Classy's templates directory. Include all templates, even ones without classes.
- Remove all classes from the core module's template. Remove all classes added with addClass and ones that are hard-coded in the template.
- If there are classes that are required for basic functionality, discuss whether they should be kept.
- If there is CSS from the module, or anywhere else, referring to the class, discuss removing it or moving it to Bartik&Seven. Do not move the CSS to Classy.
Twig Templates to Copy
core/modules/comment/templates/comment.html.twig
core/modules/comment/templates/field--comment.html.twig
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | copy_commment_templates_2349659-11.patch | 9.54 KB | Maninders |
| #8 | copy_comment_templates-2349659-8.patch | 1.59 KB | lauriii |
Comments
Comment #1
mortendk CreditAttribution: mortendk commentedmoved the classes out of core
Discussion of the classes - should be done as a follow up, so bikesheedding wont stop classy ;)
Comment #3
davidhernandezThe comment preprocess changes aren't in yet. #2329783: Move comment classes from preprocess to templates
Comment #4
davidhernandezPlease double-check if any removed classes are being used in javascript. It is best to test the affected template using Stark to make sure nothing is broken.
Comment #5
emma.mariaComment #8
lauriiiComment #9
lauriiiThis is still postponed by #2217731: Move field classes out of preprocess and into templates
Comment #10
davidhernandezThe field issue has been committed.
Comment #11
Maninders CreditAttribution: Maninders commentedComment #12
Maninders CreditAttribution: Maninders commentedDone with the changes, 2349659-11.
Comment #13
Maninders CreditAttribution: Maninders commentedComment #14
LewisNymanI tested the patch in Stark and nothing looked broken. I also compared the markup Stark markup in HEAD and the Classy markup with the patch to make sure they matched. They do.
Comment #15
alexpottTemplate change is not frozen in beta. Committed c0b45ec and pushed to 8.0.x. Thanks!
Comment #18
Maninders CreditAttribution: Maninders at Srijan | A Material+ Company commentedComment #19
Maninders CreditAttribution: Maninders at Srijan | A Material+ Company commented