Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.(First, verify that the preprocess changes have been made. #2322163: [meta] Consensus Banana Phase 1, move CSS classes from preprocess to twig templates.)
- Copy the Twig templates from the core module's templates directory to Classy's templates directory. Include all templates, even ones without classes.
- Remove all classes from the core module's template. Remove all classes added with addClass and ones that are hard-coded in the template.
- If there are classes that are required for basic functionality, discuss whether they should be kept.
- If there is CSS from the module, or anywhere else, referring to the class, discuss removing it or moving it to Bartik&Seven. Do not move the CSS to Classy.
Twig Templates to Copy
core/modules/search/templates/search-result.html.twig
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | copy_search_templates-2349731-1.patch | 3.74 KB | lauriii |
Comments
Comment #1
lauriiiComment #2
derheap CreditAttribution: derheap commentedTagging cssbanana, as there is one css rule. But it is not used in this template.
(Just tried to upload the same patch – )
Comment #3
mortendk CreditAttribution: mortendk commentedComment #4
runand CreditAttribution: runand commentedComment #5
runand CreditAttribution: runand commentedLooks good.
Comment #6
davidhernandezI'm universally setting all the phase 2 issues back to needs review, because we're missing some things. Please double-check if any removed classes are being used in javascript. It is best to test the affected template using Stark to make sure nothing is broken.
Comment #7
mortendk CreditAttribution: mortendk commentedno js conflicts here
Comment #8
alexpottThe only css class used is
search-snippet-infoand it is in bartik so all good here.Committed 7e23406 and pushed to 8.0.x. Thanks!
This normal task was committed due the fact the banana consensus received per approval wrt to #2350615: [policy, no patch] What changes can be accepted during the Drupal 8 beta phase?