Problem/Motivation

The automatic download of translation files has a hidden dependency on the Update Manager (update).
When the user opts out of notifications during the Standard Profile installation, the Update Manager is not enabled and the locale module does not communicate the missing dependency. this can lead to confusing behaviour or false help text in a few places:

On "/admin/config/regional/translate/import"
helptext issue

"Translation files are automatically downloaded and imported when languages are added, or when modules or themes are enabled."

This is true only if the Update Manager is enabled.
On the same page, the different ways to import translations are explained. In this help text a reference to the automatic download via the report page "Available Translations Update" is missing.

On "/admin/reports/translations"
helptext issue
The manual check is performed without notifying the user, that Update Manager is required for it to function. Instead it will show a status message suggesting everything is OK.

Proposed resolution

Creating a hard dependency on Update Manager is not desirable, as the modules can function without it.
Suggestion: show a message of type "warning" or "error" on the report page when a manual check is performed without update enabled, highlighting this problem.

Remaining tasks

Change help text to explain dependency on update module
Add status message to report page if update is disabled.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Bug because translations are never imported, and the user isn't informed on how to get them working without this fix
Unfrozen changes Unfrozen because it only changes the user interface to be more usable (UX)
Prioritized changes The main goal of this issue is usability.
CommentFileSizeAuthor
#11 patch_error.JPG123.43 KBTruptti
#8 interdiff-5-8.txt961 bytespiyuesh23
#8 2349743-auto-translate-dependency-5.patch-8.patch2.87 KBpiyuesh23
#5 2349743-auto-translate-dependency-5.patch2.87 KBbanviktor
#3 2349743-3-auto-translate-dependency.patch2.86 KBrvilar
translations_import_02.png26.11 KBcjoy
translations_import_01.png69.88 KBcjoy
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rvilar’s picture

rvilar
Primary language Catalan
Location Montcada i Reixac, Catalonia
CreditAttribution: rvilar commented
Assigned: Unassigned » rvilar

I'm starting to work on that

aimeerae’s picture

aimeerae
she/her
Primary language English
Location San Francisco, CA
CreditAttribution: aimeerae commented
Issue summary: View changes
Related issues: +#2026871: Available translation updates page doesn't warn user if Update Manager module is disabled
rvilar’s picture

rvilar
Primary language Catalan
Location Montcada i Reixac, Catalonia
CreditAttribution: rvilar commented
Status: Active » Needs review
FileSize
2349743-3-auto-translate-dependency.patch2.86 KB

I attach a patch that updates the report page to add the message when you haven't Update module enabled and updated the messatge in language page too

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom commented
Status: Needs review » Needs work
Issue tags: +Needs reroll

Patch no longer applies.

banviktor’s picture

banviktor CreditAttribution: banviktor commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
2349743-auto-translate-dependency-5.patch2.87 KB

rerolled

banviktor’s picture

banviktor CreditAttribution: banviktor commented
Assigned: rvilar » Unassigned
jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom commented
Issue summary: View changes

This looks good. One small nit though:

+++ b/core/modules/locale/locale.batch.inc
@@ -110,7 +110,13 @@ function locale_translation_batch_status_finished($success, $results) {
+        '@module' => \Drupal::url('system.modules_list'),

Shouldn't this be !module? (Although I can't really imagine anything in the resultant url being escaped since it will be relative).

I've added a beta-phase evaluation to the issue summary.

piyuesh23’s picture

piyuesh23 CreditAttribution: piyuesh23 commented
FileSize
2349743-auto-translate-dependency-5.patch-8.patch2.87 KB
interdiff-5-8.txt961 bytes

Updated the file. Attaching the updated patch & interdiff below.

piyuesh23’s picture

piyuesh23 CreditAttribution: piyuesh23 commented
Issue tags: +Goa2015
piyuesh23’s picture

piyuesh23 CreditAttribution: piyuesh23 commented
Issue tags: -Goa2015 +#drupalgoa2015
Truptti’s picture

Truptti CreditAttribution: Truptti at Axelerant commented
FileSize
patch_error.JPG123.43 KB

Tried verifying the issue, but the patch in #8 gave error.Updating the status to Needs Work

Truptti’s picture

Truptti CreditAttribution: Truptti at Axelerant commented
Status: Needs review » Needs work

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev
quietone’s picture

quietone CreditAttribution: quietone at PreviousNext commented
Version: 9.3.x-dev » 9.5.x-dev
Status: Needs work » Closed (cannot reproduce)

I tested this on Drupal 9.5.x, standard install.

  1. I installed via the UI and did not tick the box for checking for updates.
  2. enable content_translation, config_translation
  3. go to admin/config/regional/language/add
  4. Add German
  5. Watch translations load
  6. Go to admin/reports/translations
  7. Click check manually
  8. Get message
    Status message</li>
  <li>Checked available interface translation updates for one project

Seems to be fixed.

Therefore, closing as cannot reproduce. If you are experiencing this problem on a supported version of Drupal reopen the issue, by setting the status to 'Active', and provide complete steps to reproduce the issue (starting from "Install Drupal core").

Thanks!

quietone’s picture

quietone CreditAttribution: quietone at PreviousNext commented