Copy system templates to Classy

this is gonna be a pita ...

Copied files and removed classes

I worked on the time.html.twig and on vertical-tabs.html.twig file.

Copied files and removed classes from these files select.html.twig, status-messages.html.twig, status-report.html.twig

patch added for
core/modules/system/templates/system-admin-index.html.twig
core/modules/system/templates/system-config-form.html.twig
core/modules/system/templates/system-themes-page.html.twig
core/modules/system/templates/table.html.twig
core/modules/system/templates/tablesort-indicator.html.twig
core/modules/system/templates/task-list.html.twig
core/modules/system/templates/textarea.html.twig

I added
core/theme/classy/templates/install-page.html.twig
core/theme/classy/templates/item-list.html.twig
core/theme/classy/templates/links.html.twig
core/theme/classy/templates/maintenance-page.html.twig
core/theme/classy/templates/mark.html.twig
core/theme/system/classy/menu-local-action.html.twig
and removed classes from the same files in the core/module/system/templates/..

patch

patch added for

core/themes/classy/templates/form-element.html.twig
core/themes/classy/templates/form.html.twig
core/themes/classy/templates/html.html.twig
core/themes/classy/templates/image.html.twig
core/themes/classy/templates/indentation.html.twig
core/themes/classy/templates/input.html.twig

added new file

patch added for
core/modules/system/templates/menu-local-task.html.twig
core/modules/system/templates/menu-local-tasks.html.twig
core/modules/system/templates/menu.html.twig
core/modules/system/templates/page.html.twig
core/modules/system/templates/pager.html.twig
core/modules/system/templates/progress-bar.html.twig

Patch added for
core/modules/system/templates/details.html.twig
core/modules/system/templates/dropbutton-wrapper.html.twig
core/modules/system/templates/feed-icon.html.twig
core/modules/system/templates/field-multiple-value-form.html.twig
core/modules/system/templates/field.html.twig
core/modules/system/templates/fieldset.html.twig
core/modules/system/templates/form-element-label.html.twig

Updated the name of the patch file

Remove and add classes from radios.html.twig, region.html.twig, system-admin-index.html.twig

File name :
core/modules/system/templates/admin-block-content.html.twig
core/modules/system/templates/admin-block.html.twig
core/modules/system/templates/admin-page.html.twig
core/modules/system/templates/block--system-branding-block.html.twig
core/modules/system/templates/block--system-menu-block.html.twig

File name :
core/modules/system/templates/admin-block-content.html.twig

Files name :
core/modules/system/templates/breadcrumb.html.twig
core/modules/system/templates/checkboxes.html.twig
core/modules/system/templates/confirm-form.html.twig
core/modules/system/templates/container.html.twig
core/modules/system/templates/datetime-form.html.twig
core/modules/system/templates/datetime-wrapper.html.twig

Recorrection of patch no 23.
Files:
core/modules/system/templates/breadcrumb.html.twig
core/modules/system/templates/checkboxes.html.twig
core/modules/system/templates/confirm-form.html.twig
core/modules/system/templates/container.html.twig
core/modules/system/templates/datetime-form.html.twig
core/modules/system/templates/datetime-wrapper.html.twig

Retrying as test bot failed with message,

Detect a Drupal installation failure. 
Ensure that you can perform a fresh Drupal install.

+1 for breaking this issue. Doing the same alphabetically sounds okay to me. Let me know if I can create the meta issues.

Done! List of issues below,

• #2407713: Copy system templates a*.html.twig to Classy
• #2407715: Remove classes from system templates b*.html.twig
• #2407723: Remove classes from system templates c*.html.twig
• #2407725: Remove classes from system templates d*.html.twig
• #2407727: Remove classes from system templates f*.html.twig
• #2407729: Remove classes from system templates h*.html.twig
• #2407733: Remove classes from system templates i*.html.twig
• #2407735: Remove classes from system templates m*.html.twig
• #2407737: Remove classes from system templates p*.html.twig
• #2407739: Remove classes from system templates r*.html.twig
• #2407743: Remove classes from system templates s*.html.twig
• #2407745: Remove classes from system templates t*.html.twig
• #2407747: Copy system templates v*.html.twig to Classy
• #2407749: Copy system templates l*.html.twig to Classy

As a change from davidhernandez's suggestion, I have mentioned this issue (#2349759: Copy system templates to Classy) as parent, to have proper hierarchy and #2348543: [meta] Consensus Banana Phase 2, transition templates to the starterkit theme as related issue.

I hope this is fine. If any change needed, I can update issues as appropriate.

patch for
core/modules/system/templates/breadcrumb.html.twig
core/modules/system/templates/checkboxes.html.twig
core/modules/system/templates/confirm-form.html.twig
core/modules/system/templates/container.html.twig
core/modules/system/templates/datetime-form.html.twig
core/modules/system/templates/datetime-wrapper.html.twig

This issue could really do with a summary to explain the rationale for why we're doing this. Because at first glance, this seems to add a pretty big maintenance burden. Now, all routine bug fixes such as #2409817: CKEditor toolbar configuration UI missing ending UL need to be made in two places. Further, rather than the current state in e.g. Bartik where only the template files that themers are mostly likely to want to override being there for easy copy/paste/modify, we're copying *all* of the template files there, even relatively silly ones that only 0.000001% of people would ever override like, for example, the very ckeditor-settings-toolbar.html.twig from that issue, drowning out the "99% cases" (e.g. node.html.twig) in the process. And finally, the very nice-on-the-surface "Simply copy/paste/modify the template in Classy" breaks down as soon as you install a contributed module which of course naturally will not be able to put its stuff in themes/classy.

I raised these concerns with davidhernandez in IRC. He said that the rationale for this change is for usability, so themers don't need to learn weird things like that it's actually System module that provides field.html.twig, not Field module. Also, that if we don't copy all of them, we have to decide on a case-by-case which ones we're going to copy, and then also explain that to themer somehow. "In core vs. not in core" is much easier to document than "In core and arbitrarily decided upon by a committee to be important to themers." He also said this plan already has approval from Alex Pott, so I guess that's fair enough.

However, if that's the case, and we really do want to duplicate 100% of core's templates in Classy, then let's please do it as a single big patch and "rip off the band-aid" once (rather than 20 sub-issues), and from the time that's committed on, duplicate changes / add templates /etc. in both places (and publish a change record to this effect). As opposed to the current situation where it's very tricky to tell if a bug fix should be committed in two places or not without manual checking to see if it's one of the lucky templates that's been copied over yet.

I feel that all the sub issues should be closed and that this issue should be about deciding what should be copied to classy from system. There are templates for the front- and back- end here. I think all the front-end templates should be copied and we should leave the back-end templates where they are. If we can't decide whether something is front or back then we should err on the side of copying. But, for example, I don't think we should be overwhelming front-end developers with things like system-admin-index.html.twig

My feeling for a while has been that classes that are relevant for system UI should stay within core. For example, the admin toolbar and contextual links should still work if you're using a theme based strictly on core and not on classy. I think that argument holds for template files that are geared towards creating back-end UI rather than user-facing templates.

The argument for moving over everything into Classy would probably be that it would make it easier to create an admin theme from scratch, but it's pretty rare that somebody needs to make an admin theme.

I think it's a solid point that putting a ton of templates that few people will likely change makes things more confusing.

I also agree that if there is any question on whether a template is something that is likely to be themed, it's probably better to err on the side of putting it in Classy.

That's my two cents.

the only reason its rare to make admin themes in drupal is that its so %#€%" hard
pretty please lets not do the same mistakes again as we have done with drupal before and only make a bit of the templates visible for the themer.
its inconsistence and gonna bite us further down the road.

re #44 - I think toolbar and contextual should stay classed in core - since there functionality depends on it. But there should be copies in classy. Because these templates affect the front end. Especially contextual - since content creation and editing is a common task for people that only see the front page. The toolbars templates I'm happy for a consensus to be build - not really fussed.

From a quick glance I would not copy views_ui, color, locale, language, simpletest, update, and the admin templates in system. The admin templates in system are (i think) admin-*, system-*, status-*, install-page and maintenance-task-list

Oh and contextual does not have it's own templates so does not need to be part of the discussion afaics.

status messages is used on the normal frontend, so it should be there
- im gonna rant later on about the missing templates that are admin templates, but should not be treated differently.
Even the admin need's a little theme love ;)

not copied over:

admin-block-content.html.twig
admin-block.html.twig
admin-page.html.twig
install-page.html.twig
maintenance-task-list.html.twig
status-report.html.twig
system-admin-index.html.twig
system-config-form.html.twig
system-themes-page.html.twig

RTBC it, as its not the end of the world & a huge pita of a bikeshed if were gonna discuss this now, thats for a later issue :)

The system folder seems a bit crowded.. could we organize it a bit ? Grouping these two into their own directories would make it easier for people to find them... sorry if this has already been discussed though! ;)

system/form:

• form-element.html.twig
• form-element-label.html.twig
• form.html.twig
• confirm-form.html.twig
• field-multiple-value-form.html.twig
• input.html.twig
• radios.html.twig
• select.html.twig
• textarea.html.twig
• datetime-form.html.twig

system/menu:

• block--system-menu-block.html.twig
• menu.html.twig
• menu-local-action.html.twig
• menu-local-task.html.twig
• menu-local-tasks.html.twig

@manual nope were gonna do that in seperate issues, this needs to be as small as possible

fixed the issue as well with block--system-menu-block.html.twig that should be extending on classy not system.

we need an issue on this behaviour, as its strange but works.
{% extends "@classy/system/block--system-menu-block.html.twig" %}

Looks good! Reviewed admin pages and everything seems to be working well.

+{% extends "@classy/search/block--search-form-block.html.twig" %}

Shouldn't this work: {% extends "block--search-form-block.html.twig" %} assuming block--search-form-block.html.twig is in Classy I would have thought Bartik will just pick it up and use it, since we have the registry discovery system now for templates?

Correct me if I am wrong, I just assumed that would work, I'm doing something similar now but a bit different, sorry no time to test as its 11:40pm and I must be shoving off for the day :/

#57 shouldn't remove RTBC, please see #2387069: {% extends "foo.html.twig" %} in Twig templates does not respect theme inheritance. Removing the namespace results in an infinite loop.

The patch just adds new files - so everything is duplicated. The patch should be really small - it should tell us that a load of files are moving and that there are some minor edits.

#58 ok, we probably need to document some details around that - so a recursion only occurs if you try to extend the current template? Thanks for pointing this out, cheers!

I think it's fixed now.

@ruben no files are moved over ?

Ops, wrong diff!

Aaaarghh! What about now?

fix git issues locally & rerolled -3

We could also change the template extends #2291449: Add Twig template inheritance based on the theme registry, enable adding Twig loaders

@laurii are you about to scope creep on this ;) ?

@lauriii - check #57/#58, because it's calling its parent template in the registry that is not possible, at least not currently.

Back to RTBC. Let's merge this!

Templates are not frozen in beta. Committed b76f263 and pushed to 8.0.x. Thanks!

I also added crowdcg, sivaji@knackforge.com, dernetzjaeger from the postponed sub issues to the commit credit.