Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
(First, verify that the preprocess changes have been made. #2322163: [meta] Consensus Banana Phase 1, move CSS classes from preprocess to twig templates.)
- Copy the Twig templates from the core module's templates directory to Classy's templates directory. Include all templates, even ones without classes.
- Remove all classes from the core module's template. Remove all classes added with addClass and ones that are hard-coded in the template.
- If there are classes that are required for basic functionality, discuss whether they should be kept.
- If there is CSS from the module, or anywhere else, referring to the class, discuss removing it or moving it to Bartik&Seven. Do not move the CSS to Classy.
Twig Templates to Copy
core/modules/update/templates/update-last-check.html.twig
core/modules/update/templates/update-project-status.html.twig
core/modules/update/templates/update-report.html.twig
core/modules/update/templates/update-version.html.twig
Comment | File | Size | Author |
---|---|---|---|
#5 | copy_update_templates-2349769-5.patch | 13.96 KB | cilefen |
#5 | interdiff-2-5.txt | 15.21 KB | cilefen |
#2 | copy_update_templates-2349769-2.patch | 12.29 KB | cilefen |
Comments
Comment #1
cilefen CreditAttribution: cilefen commentedComment #2
cilefen CreditAttribution: cilefen commentedI think we want to move all of
core/modules/update/css/update.admin.css
to Seven.Comment #3
cilefen CreditAttribution: cilefen commentedThese classes may be considered essential to the module's function.
Also, these may be considered essential to the module's function. But since in this case this module is admin-only, it may be fine if they exist in Seven only.
Comment #5
cilefen CreditAttribution: cilefen commentedI moved the templates from class/templates/update to classy/templates and edited a test that referenced the class names.
Comment #6
davidhernandezPlease double-check if any removed classes are being used in javascript. It is best to test the affected template using Stark to make sure nothing is broken.
Comment #7
cilefen CreditAttribution: cilefen commented@davidhernandez - Thank for checking on the JS situation.
The update templates seem to work in Stark, but I should not be the last word. To anyone else testing, the update module paths are:
Comment #10
cilefen CreditAttribution: cilefen commentedSee https://www.drupal.org/node/2348543#comment-9564823
Comment #11
lauriiiComment #12
joelpittetAutomated triage: bumping to 9.0.x because our API base themes (stable and classy) are locked in with the release of 8.0.x.
Comment #13
catchMoving back to 8.3.x and minor per #2349661: Copy config_translation templates to Classy.
Comment #26
quietone CreditAttribution: quietone at PreviousNext commentedAsked in #frontend and andy-blum replied that this should move to the contrib project.