Twig Double escaping on modules' available updates page

I did some manual testing and everything seems to work fine.

I also had a look on the issue - patch applies fine for me and the result is as expected.

I think we can set the issue to RTBC.

      $recommended_release = $project['releases'][$project['recommended']];
      $recommended_version = $recommended_release['version'] . ' ' . _l($this->t('(Release notes)'), $recommended_release['release_link'], array('attributes' => array('title' => $this->t('Release notes for @project_title', array('@project_title' => $project['title'])))));
      if ($recommended_release['version_major'] != $project['existing_major']) {
        $recommended_version .= '<div title="Major upgrade warning" class="update-major-version-warning">' . $this->t('This update is a major version update which means that it may not be backwards compatible with your currently running version.  It is recommended that you read the release notes and proceed at your own risk.') . '</div>';
      }

Can we convert this to an actual twig template rather than just adding html together. So it is something like

$template = "{{ release_version }} <a href="{{ release_link }}" title="{{ 'Release notes for'|t }} {{ project_title }}">{{ 'Release notes'|t }}</a>";

The code looks good, and follows @alexpott's suggestions. Tested the patch and it is working. Good work @Zekvyrin. Images attached for comparison.

+++ b/core/modules/update/src/Form/UpdateManagerUpdate.php
@@ -134,16 +134,26 @@ public function buildForm(array $form, FormStateInterface $form_state) {
+      $recommended_version = "{{ release_version }} (<a href=\"{{ release_link }}\" title=\"{{ 'Release notes for'|t }} {{ project_title }}\">{{ 'Release notes'|t }}</a>)";
...
+        $recommended_version .= "<div title=\"Major upgrade warning\" class=\"update-major-version-warning\">{{'This update is a major version update which means that it may not be backwards compatible with your currently running version.  It is recommended that you read the release notes and proceed at your own risk.'|t }}</div>";

There are numerous problems with this:

1. There is no way the translation extractor will find this. See #2315329: Support for Drupal 8 inline twig translatable for constructs the extractor can support. A random variable changed several ways and then later used in a render API construct will not suffice.

2. The words "Major upgrade warning" are not translatable. Not a problem of this patch, but while you are at it.

3. The change from "Release notes for @project_title" to essentially "Release notes for" . $project_title is very bad for translation. Are you sure all languages that Drupal may be translated to will find this word order suitable? The goal of having the token to replace in the text is exactly to support different languages. Doing the string concatenation instead will not be compatible by several languages.

#14:

{{ 'Author: @author'|t({'@author' : author})  }}

OR

{% trans %}
  Author: {{ author }}
{% endtrans %}

Posting patch. Solving 2. and 3. from #12.

Looks good to me. Fixes #12.2 and #12.3. What are we gonna do with #12.1?

Should this works for it?

Can you provide us a interdiff?

Here u r

+++ b/core/modules/update/src/Form/UpdateManagerUpdate.php
@@ -134,16 +134,29 @@ public function buildForm(array $form, FormStateInterface $form_state) {
+          'project_title' => $this->t('Release notes for @project_title',array('@project_title'=>$project['title'])),

Space missing after first parameter, and around array key value. Change it to this:
$this->t('Release notes for @project_title', array('@project_title' => $project['title']))

+++ b/core/modules/update/src/Form/UpdateManagerUpdate.php
@@ -134,16 +134,29 @@ public function buildForm(array $form, FormStateInterface $form_state) {
+        $recommended_version = "{{ release_version }} (<a href=\"{{ release_link }}\" title=\"{{ project_title }}\">{{ release_notes }}</a>)";

Can't we use l() function here.

#25 - can I pass title parameter to l() function?

@mirom see LinkGeneratorInterface::generate()

I dont think we are using l() function in a template or am I wrong?

ahh.. I get it. In that case we do not need l() function.

+++ b/core/modules/update/src/Form/UpdateManagerUpdate.php
@@ -134,16 +134,29 @@ public function buildForm(array $form, FormStateInterface $form_state) {
+        '#context' => [

I am not sure whether this is correct. I think #context should contain elements within array(), like this:

'#context' => array(
...
),

It is probably my typo. Submitting correct patch and interdiff with #18.

1. +++ b/core/modules/update/src/Form/UpdateManagerUpdate.php
   @@ -134,16 +134,29 @@ public function buildForm(array $form, FormStateInterface $form_state) {
   +        $recommended_version = "{{ release_version }} (<a href=\"{{ release_link }}\" title=\"{{ project_title }}\">{{ release_notes }}</a>)";
   

   Indentation not correct

2. +++ b/core/modules/update/src/Form/UpdateManagerUpdate.php
   @@ -134,16 +134,29 @@ public function buildForm(array $form, FormStateInterface $form_state) {
   +          'project_title' => $this->t('Release notes for @project_title',array('@project_title' => $project['title'])),
   

   Space missing after first parameter *again* :)

@mirom Please change it to needs review after it is done

This approach definitely fixes the translatability concerns, thanks a lot.

@subhojit777 - hopefully fixed, first time i didn't see, what you mean by "space after first parameter"

Submitting correct patch and interdiff with #18.

This needs a re-roll, because it's in a table it's quite difficult to move this markup to a template to so this approach looks like the most viable.

Couple of nitpicks as well:

1. +++ b/core/modules/update/src/Form/UpdateManagerUpdate.php
   @@ -134,16 +134,29 @@ public function buildForm(array $form, FormStateInterface $form_state) {
   +      $recommended_version = "{{ release_version }} (<a href=\"{{ release_link }}\" title=\"{{ project_title }}\">{{ release_notes }}</a>)";
   ...
   +        $recommended_version .= "<div title=\"{{ major_update_warning_title }}\" class=\"update-major-version-warning\">{{ major_update_warning_text }}</div>";
   

   Would be nice without as many quote escapes, could you swap the " with '.

   "<div title=\"{ to '<div title="{

2. +++ b/core/modules/update/src/Form/UpdateManagerUpdate.php
   @@ -134,16 +134,29 @@ public function buildForm(array $form, FormStateInterface $form_state) {
   +          'major_update_warning_text' => $this->t('This update is a major version update which means that it may not be backwards compatible with your currently running version.  It is recommended that you read the release notes and proceed at your own risk.'),
   

   There is a double space after the period in the sentence.

Edit: Removed comment (wrong issue)

Rerolled and did the changes

Patch in #38 is working. And the code looks alright.

This issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed 169fde0 and pushed to 8.0.x. Thanks!