#2343943: Language domain may not be left blank for default language added a new test which included a call to gethostname(), which broke testbot NG, and was subsequently replaced with a bunch of extra fancy code in #2350543: #2343943 introduced gethostname(), which breaks on new testbot .

However, I don't believe any of this super fancy code is required, since the IT domain, for example, is fake, so we could just fake the english domain too? Going to test whether that theory is true.

CommentFileSizeAuthor
#1 language-tests-2350937.patch2.26 KBwebchick
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

webchick’s picture

Status: Active » Closed (works as designed)
FileSize
2.26 KB

Hm. Dang. :( Doesn't work like I thought, so apparently that fanciness is required.

Here's the patch for anyone morbidly curious. But I get 5 fails, all stemming from:

GET http://example.com:8083/admin/config/regional/language/detection/url returned 0 (0 bytes).

Gábor Hojtsy’s picture

Yeah when you set a default domain, form submit works and then it redirects you back to a results page (normal Drupal behaviour) now using the newly set domain. If you set it to a domain that is not served by the tested system, then it will not work. We need to dynamically get that domain. The problem in #2350543: #2343943 introduced gethostname(), which breaks on new testbot was that the new testbots return different domain names for the testing and tested systems so we could not use just PHP.

YesCT’s picture

Issue tags: -Amsterdam 2014 +Amsterdam2014

fixing the tag, so I can delete the least used one.