Some of Bartik's Twig templates contain comments indicating the closing tags for each HTML element in the template.
For example here is the end of the page.html.twig file...
</div> <!-- /#footer -->
{% endif %}
</footer> <!-- /.section -->
</div> <!-- /#footer-wrapper -->
</div> <!-- /#page -->
</div> <!-- /#page-wrapper -->
No other theme follows this practice and with work such as #1903048: Revise Bartik template indentation inline with best practices. you can clearly see from just structuring the code correctly what belongs to what.
These comments also print in the frontend when you look at the markup. It looks like we haven't tidied up after ourselves and we want to show a good example with Bartik.
Please can the <!--/ .... >
comments be removed.
Beta phase evaluation
Issue category | Task because it is removing comments from template files, these end tag comments are not part of coding standards. |
---|---|
Issue priority | Not critical because code cleanup |
Unfrozen changes | Unfrozen because it only removes comments from templates. |
Comment | File | Size | Author |
---|---|---|---|
#10 | remove_closing_tag-2395825-10.patch | 5.37 KB | DickJohnson |
#6 | remove_closing_tag-2395825-6.patch.diff | 5.17 KB | jennyOlsen |
#4 | Screen Shot 2014-12-18 at 22.44.10.png | 91.7 KB | emma.maria |
Comments
Comment #1
emma.mariaComment #2
emma.mariaComment #3
emma.mariaComment #4
emma.mariaComment #5
jennyOlsen CreditAttribution: jennyOlsen commentedComment #6
jennyOlsen CreditAttribution: jennyOlsen commentedAttached patch removes the html comments from the Bartik template files
Comment #7
jennyOlsen CreditAttribution: jennyOlsen commentedComment #8
star-szrSetting to needs review so the patch gets tested :)
Comment #9
joelpittetIt's going to conflict a bit with #1903048: Revise Bartik template indentation inline with best practices. so postpone on that one, unless you want to RTBC them both and just re-roll after commit?
Comment #10
DickJohnson CreditAttribution: DickJohnson commentedRerolled after #1903048: Revise Bartik template indentation inline with best practices. was commited.
Comment #11
LewisNymanI had a quick check to make sure that the indentations were not changed by the patch and they aren't! Thanks
Comment #12
emma.mariaI manually compared templates side by side and comments are removed with no changes or breaks to anything else. RTBC++
Comment #13
emma.mariaAdded the Beta evaluation to the issue summary.
Comment #14
alexpottCommitted a92c3a1 and pushed to 8.0.x. Thanks!
Thanks for adding the beta evaluation for to the issue summary.