Currently Fieldable Panels Panes only invokes the base entity_insert, entity_update, and entity_presave. It does not also invoke an entity type specific hook like other modules do (Comments, Nodes, etc.) This can make hooking on FPP entity controller saves a bit bulky.

Patch incoming.

CommentFileSizeAuthor
#1 add-2398301-1.patch1.73 KBmglaman

Comments

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Active » Needs review
StatusFileSize
new add-2398301-1.patch1.73 KB

Followed pattern found in other modules - entity specific hook, general entity hook.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Needs work
Parent issue: » #2244541: [meta] Plan for Fieldable Panels Pane 7.x-1.6 release

I think this would be a good time to add a fieldable_panels_panes.api.php, and hook_hook_info().

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Assigned: Unassigned » mglaman

:) Sounds like a proper improvement, and holiday present for the project.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Reviewed & tested by the community

Lets move documentation into #2398759: Document all APIs.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Reviewed & tested by the community » Fixed

Committed. Thanks.

  • DamienMcKenna committed 3fed0f4 on 7.x-1.x authored by mglaman 
    Issue #2398301 by mglaman: Add hook_fieldable_panels_pane_insert/update/...
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Assigned: mglaman » Unassigned

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.