Could this version please be updated to be compatible with version D6?

I wish to make a website using this module, but they aren't compatible with the latest version of the drupal core D6. So an update of the code would be really needed.

Thank you so much in advance.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

robertgarrigos’s picture

Assigned: mrmark » robertgarrigos
Category: task » feature
Priority: Critical » Normal
Status: Needs work » Active

I'll work on this.

swentel’s picture

FileSize
5.86 KB

Hi, I have a first attempt to port this module to D6.
It's a patch against 5.x-2.0-beta1, but

  • It now only works for first level menu's (ie, navigation, primary-links) , so I've should have done it against 5.x.1 version.
  • Didn't include the info file for now (if someone wants to test, just add 'core = 6.x' to the info file).

It works fine here, but I'm not sure if it's the right way since the menu system was completely overhauled. The patch completely overhauled the module codewise too because of this. I do hope it's a good starting point though.

swentel’s picture

Status: Active » Needs work
MatthijsG’s picture

* subscribing

thomas23@drupal.org’s picture

subscribing...

thomas23@drupal.org’s picture

Priority: Normal » Critical

On my site it doesn't work at all. First when enabling the module I got this warning

warning: Missing argument 1 for menu_block_split_menu() in /home/www/drupal/sites/all/modules/menu_block_split/menu_block_split.module on line 21.

I changed menu_hook to this:

<?php
function menu_block_split_menu() {
  $items['admin/settings/mbs'] = array(
      'title' => t('Menu block split'),
      'access' => user_access('maintain personal blog'),
      'callback' => 'drupal_get_form',
      'callback arguments' => array('menu_block_split_settings'),
      'access' => user_access('administer menu block split'),
      'description' => t('Settings for Menu Block Split'),
    ); 
  return $items;
}
?>

Now I get no warning and also the permissions flag all right. But still no set-up options (haven't used this module before) and /admin/settings/mbs has access denied.

Would appreciate people with more insides to look at this.

Cheers.

thomas23@drupal.org’s picture

Version: 5.x-1.x-dev » 6.x-1.x-dev
thomas23@drupal.org’s picture

Title: Update to be D6 compatible » Update menu_block_split to be D6 compatible
B00N’s picture

Assigned: robertgarrigos » B00N
Category: feature » support
Priority: Critical » Normal
Status: Needs work » Active
FileSize
9.44 KB

Hi,

i made a new version for version 6.x, based on the 5.x-2.0-beta1 version. It works fine for me, maybe someone need it.

Greets Franzer

robertgarrigos’s picture

Status: Active » Needs review
FileSize
2.79 KB

Thanks Franzer. I reviewed your code and made some minors changes to:

1.- Not trigger any error when php is set to show all errors and notices
2.- To be able to use the navigation menu (system module) as well as any user created menu (menu module). It wasn't working with the navigation menu.
3.- There is a few lines in one function which are not being used, so I commented them as they were triggering a php notice error

I upload a patch to apply on the previous uploaded file. Would you review this patch, please, so I could create a new beta release for this version 6 if this is OK?

Thanks again.

swentel’s picture

Status: Needs review » Reviewed & tested by the community

Downloaded the beta and did the patch in #10.
Works fine here. marking as rtbc

B00N’s picture

Hi,

i also reviewed the code and tested the module. It works. Please create a new beta release.

I think about a other modification: A flag in the settings, where the user can decide whether the level 0 marked active when sub-items are selected.

Franzer

thomas23@drupal.org’s picture

FranZer, a very nice and usefull idea. I'd like to see this option and would test it.

Cheers.

B00N’s picture

so, here's the promised patch and also a new *.pot and a german language file.

robertgarrigos’s picture

Thanks you for your work. There is a new 6.x-1.2 release. I forgot to include the pot file into the release, so it is only in the dev tarball. It'll be included in a next release.

robertgarrigos’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.