This form was recently converted to save #2355909: language.settings config is not scalable the settings into configuration entities. ContentLanguageSettingsForm use ConfigFormBase but does not save configuration.

Blocks #2392319: Config objects (but not config entities) should by default be immutable

CommentFileSizeAuthor
#3 2403101.3.patch2.2 KBalexpott
#3 1-3-interdiff.txt2.2 KBalexpott
d8.content-language-settings-form.patch1.25 KBalexpott
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Issue tags: +Quick fix

Status: Needs review » Needs work

The last submitted patch, d8.content-language-settings-form.patch, failed testing.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Needs work » Needs review
FileSize
1-3-interdiff.txt2.2 KB
2403101.3.patch2.2 KB

Fixed constructor by removing call to parent and unnecessary injection of the config factory.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Needs review » Reviewed & tested by the community

Looks good, fixes what the scope was set out to do. While not critical in its own right, blocks the critical at #2392319: Config objects (but not config entities) should by default be immutable.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.0.x, thanks!

  • catch committed 9e91941 on 8.0.x 
    Issue #2403101 by alexpott: ContentLanguageSettingsForm is not a config...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.