Problem/Motivation

remove non essential classes from core/modules/system/templates/html.html.twig

Proposed resolution

Remaining tasks

User interface changes

API changes

Original report by @sivaji@knackforge.com

CommentFileSizeAuthor
#4 remove_classes_from-2407729-4.patch892 bytesmortendk
#1 issue-2407729-1.patch2.09 KBSivaji_Ganesh_Jojodae
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Sivaji_Ganesh_Jojodae’s picture

Sivaji_Ganesh_Jojodae CreditAttribution: Sivaji_Ganesh_Jojodae commented
Status: Active » Needs review
FileSize
issue-2407729-1.patch2.09 KB
davidhernandez’s picture

davidhernandez
Primary language English
Location USA
CreditAttribution: davidhernandez commented
Status: Needs review » Postponed

Postponing this until we decide how we are moving forward. Keep an eye on #2348543: [meta] Consensus Banana Phase 2, transition templates to the starterkit theme for updates. Thanks.

davidhernandez’s picture

davidhernandez
Primary language English
Location USA
CreditAttribution: davidhernandez commented
Title: Copy system templates h*.html.twig to Classy » Remove classes from system templates h*.html.twig
Issue summary: View changes
Status: Postponed » Needs work

Un-postponing. The templates have been copied to Classy, so all we need to do is remove classes from the original templates.

mortendk’s picture

mortendk CreditAttribution: mortendk commented
Issue summary: View changes
Status: Needs work » Needs review
FileSize
remove_classes_from-2407729-4.patch892 bytes
davidhernandez’s picture

davidhernandez
Primary language English
Location USA
CreditAttribution: davidhernandez commented
Status: Needs review » Reviewed & tested by the community

I don't see anything attached to the classes removed. The ones left are needed.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 4: remove_classes_from-2407729-4.patch, failed testing.

Status: Needs work » Needs review

davidhernandez queued 4: remove_classes_from-2407729-4.patch for re-testing.

LewisNyman’s picture

LewisNyman
he/him
CreditAttribution: LewisNyman commented
Status: Needs review » Reviewed & tested by the community

Back to RTBC

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Classy has a copy of this template and templates are not frozen in beta. Committed 232f5a5 and pushed to 8.0.x. Thanks!

  • alexpott committed 232f5a5 on 8.0.x 
    Issue #2407729 by sivaji@knackforge.com, mortendk: Remove classes from...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.