copy text template to classy

Changing test.

@morten. I moved all three. Do you not want all three in the module? Though I admit these have got to be the three smallest templates in the world. :P

Silly to have em? From that guy that wants all the templates?? :)

From the original issue it was something about having to create theme implementations for all of them but they wouldn't contain more than their actual content. They just existed to exist.

I don't understand why that is cruft.

And the main template does nothing except extend field. I'm just surprised that you're now suggesting not to copy everything. I don't understand the rationale.

Once the Classy folder re-organization gets in, this will need a reroll. These three templates are fields, so copy them to the 'fields' folder in Classy.

#2349559: [meta] Discuss the organization of subfolders in Classy

Shouldn't these get moved into Classy's field folder, not the form folder?

It looks good!

Text Node Teaser BEFORE

Text Node Teaser AFTER

Text Node BEFORE

Text Node AFTER

+++ b/core/modules/text/templates/field--text.html.twig
@@ -4,17 +4,6 @@
- * A 'clearfix' class is added, because 'text' fields have a 'format' property
- * that allows a Text Format to be associated with the entered text, which then
- * applies filtering on output. A common use case is to align images to the left
- * or right, and without this 'clearfix' class, such aligned images may be
- * rendered outside of the 'text' field formatter's boundaries, and hence
- * overlap with other fields. By setting the 'clearfix' class on all 'text'
- * fields, we prevent that.
- *
- * @see https://www.drupal.org/node/2358529
...
-{% set attributes = attributes.addClass('clearfix') %}

Does this not still need to happen in classy's field--text.html.twig?

Since we need to keep clearfix around for compatibility with Bartik and Seven, what happens to this issue?

1. Close as won't fix?
2. Postpone on Bartik/Seven updates?
3. Copy the three files in core/modules/text/templates to classy, and not remove the clearfix in core?

So these template were specifically added for the clearfix, for Bartik, and for people to override. Moving them to Classy is fine, and the clearfix will be in Classy. Removing the clearfix from core means we end up with three empty templates. If no one objects to that, then fine. We should probably add a comment to the templates though stating why they are there.

Now that I think about it, can't we just delete these templates? Moving them to Classy means they are part of a theme, so the registry will pick them up as overrides. We wouldn't need the text_theme() function. Anyone want to test that?

I've just recently realized that both Bartik and Seven are extensions of Classy. So introducing the templates in Classy, rather than core, should be okay.

Attaching a patch along with before-and-afters in Stark and Classy.

I manually tested and see the clearfix and confirmed the correct template is getting used in Bartik.

botfail?

Committed 6195b19 and pushed to 8.0.x. Thanks!

Thanks for adding the beta evaluation to the issue summary.