String formatter should link to its translation.

So an idea I recently mentioned to @plach is that Entity::urlInfo() should automatically respect the current language if not defined explicitly.

$translation = $entity->getTranslation('de');
$translation->urlInfo()

So this would automatically add the right language to the urlInfo options unless it is already set.

i think that would be quite intuitive and should fix this and possibly other issues automatically..?

Probably even then.

If you're on /fr, and are displaying content, then some of that content might originally french, so the active language is default, but it might also be originally german and translated. Which is what $this->language() gives you anyway, I think. The only case where I'd not add it is if it is undefined or so.

Just trying out what happens if we do this :)

Not too horrible, only 2 fails! Hell is only slightly frosty.

Didn't check the other test yet, but this has an interesting... side effect. Explicitly passing along the language to the url for a link automatically adds hreflang: <a href="/node/1" hreflang="en">lV81hgzZ</a>. That makes it fail in the statistics test.

Which is not what is generated, because statistics uses that super weird node_title_list() function (it accepts a StatementInterface, WTF, @chx is going to like this :p).

Anyway, I'm wondering if we really want this behavior, because this is now also added on single-language sites, in probably a lot of places, surprised to not see more test fails. I gues most code is consistent in what it uses...

Didn't mean to set to needs review, although I guess we could use some feedback from @plach/@Gabor.

I think this makes sense. I am not concerned that it will add a little bit more semantic markup to single language sites too.

Fixing the test fails, this needs tests.

I was trying to review, but I am not sure if I understand the problem correctly. If I create a view with a page that shows the articles, they both link to the same (English) article without a language prefix. I think berdir's code in the patch in comment #12 does not run when opening the page of the view, I have put an exit() befor the return, and the page is properly displayed. Maybe it is the wanted behaviour, I am not sure.

This will probably only be relevant for views in combination with #2342045: Standard views base fields need to use same rendering as Field UI fields, for formatting, access checking, and translation consistency. it also depends on how you print the link there, but for example he Node views field plugin uses Url::fromRoute('entity.node.canonical', ['node' => $this->getValue($values, 'nid')]) instead of $values->_entity->urlInfo(). If you update it like that, then it should work, but the referenced issue will probably remove that plugin anyway.

Not actually being worked on :/

+++ b/core/modules/statistics/src/Tests/StatisticsReportsTest.php
@@ -49,7 +49,9 @@ function testPopularContentBlock() {
+    //from being added to the options.

space missing after //.

Working on this now.

Changes done as per #20.
I was not sure about the failing tests.

We also need to pass $options to the Url class, fixed that in this patch. I also tried to look at the test failures but I have no idea how to debug phpunit so I had to give up :/

My contribution here was minimal and I reviewed the code a couple of times already, I think this is ready.

Note that the 'blocker' tag added above is for #2473989: Lack of dynamic language field / filter makes shipping core views hard to be both compatible with mono and multilingual and #2476563: Entity operations links tied to original entity language, ignore everything else, which are critical.

I might be missing something but I can't see where a test of a url with a language has been added? Or is the unit test enough? This seems like something that would benefit from an integration test.

Apparently this blocks #2476563: Entity operations links tied to original entity language, ignore everything else so bumping priority.

This should fix the test fails.

+++ b/core/tests/Drupal/Tests/Core/Entity/EntityUrlTest.php
@@ -110,18 +140,24 @@ public function providerTestUrlInfoForInvalidLinkTemplate() {
+   * @return \Drupal\Core\Url The URL for this entity's link template.
+   * The URL for this entity's link template.

Blaming the storm again :P

The test coverage added in #41 looks great.

I tried to take a look at this, but it's a bit over my head for the amount of time I have left today. :(

So for now, just downgrading, per #2473989-51: Lack of dynamic language field / filter makes shipping core views hard to be both compatible with mono and multilingual. This is no longer in the critical path once #2485159: Switch admin/content from showing one translation per row to one node per row is fixed.

Committed/pushed to 8.0.x, thanks!