Move simpletest to core

subscribe. this will be a great day ...

Well, I don't really have any comments yet. The only problems I've had with SimpleTest, were caused by contrib land modules' invocation of it. So, yeah, this is really just a subscription comment. :)

Subscribing :)

Great work!

My suggestions:
1) Display alert message when CURL library not found.
2) I often click 'Clean database' button instead of 'Run tests'. :)
3) Maybe it's good to add param to limit assert messages of internal methods? For example I don't want to see successful messages about login or about creating an user. There are a lot of needless asserts in my test's result. My specific test doesn't imply 20 asserts, it does only 3 but I see all the messages.

Hello guys -- I have a checkout of the repository and started reviewing the simpletest framework. Some more information would help me. What is the current state? What has been done/accomplished? What is left to be done? What do you want me to focus on?

For example, I noticed quite a few things that are not 100% in line with Drupal. To give you two quick examples:

- Do we need SimpleTest::getVersion() ?

- SimpleTest::ignore() seems to be a function that can be removed thanks to PHP5.

Are these known issues? Do we maintain getVersion() for a reason? If you can give us a bit of a status update, that would help us reviewers. Thanks and keep up the good work.

subscribing

Trying to run all tests, I eventually end up with the error Fatal error: Class 'PatternExpectation' not found in /srv/http/localhost/htdocs/drupal7/sites/all/modules/simpletest/drupal_test_case.php on line 835.

This is the first I have seen this thread.

If there are issues with SimpleTest it would be useful if they could be placed in the SimpleTest issue queue. Looks like there are some good ideas here, some of which I will look into as soon as possible.

There are a few issue with tests that appear to be related to core functionality not working as intended. These issues are listed on the SimpleTest Roadmap for Drupal 7 thread under the heading The following are fixed issues that have comments that need to be looked at for possible problems found through testing.

But the issue here, as far as I can tell, isn't with the SimpleTest module, but in the repository of the SimpleTest library itself, which chx has made available.

Yea, the issue you brought up is. I was referring to comments #5 and #6.

Comment in #8 is irrelevant to the issue, this needs review.

subscribing

subscribing

@cwgordon7: How is my comment #8 not relevant to the issue? I checked the code out from the SVN repository and ran all tests against it, which resulted in the given error. The tests worked fine when using SimpleTest 1.0.1 RC1 (even if they did yield way too many failed tests!). Setting back to CNW, as the SVN repos hasn't been updated since the last test.

@Freso: It is not relevant because this issue is to move simpletest to core. Problems you may have had with simpletest belong in the simpletest mdule's issue queue for the timebeing. If we waited for every bug to be flattened out, nothing would ever get into core.

Actually, Freso is right, this needs to be postponed until the error is fixed.

Freso, I apologize if my comments have been shut-downy, I don't mean to be. I'm sorry if I made you feel shut down; on the contrary, we need as many reviewers as possible! I've created a new issue for the error at http://drupal.org/node/248439, as it belongs in that issue queue instead. Progress here can resume once that is dealt with.

@cwgordon7: The error I experienced came from the code in chx's Subversion repository, not from the SimpleTest module. (Using the official SimpleTest 1.0.1 RC1 didn't yield that error.) And since this bug was for reviewing chx' code (according to himself), this is why I "degraded" it from CNR to CNW. As his code had been reviewed and thus found faulty, indicating that it needed more work, I set it to just that: "code needs work".

But either way, SimpleTest is now in core, so I suppose this issue is fixed, and further issues being filed against the "simpletest.module" component.