When trying to add a menu_link, pointing to an external website, to a menu in Drupal the documentation tells you to use link_path where it has to be url.

I'll provide a small patch to update menu.api.php

CommentFileSizeAuthor
#11 interdiff_2452995_9-11.txt816 bytesJacobSanford
#11 link_path_to_url-2452995-11.patch1003 bytesJacobSanford
#9 interdiff_2452995_7-9.txt714 bytesJacobSanford
#9 link_path_to_url-2452995-9.patch880 bytesJacobSanford
#7 link_path_to_url-2452995-7.patch872 bytesashutoshsngh
#1 link_path_to_url-2452995-1.patch890 bytesJeroen
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Jeroen’s picture

Jeroen CreditAttribution: Jeroen at Wunder commented
FileSize
link_path_to_url-2452995-1.patch890 bytes
Jeroen’s picture

Jeroen CreditAttribution: Jeroen at Wunder commented
Status: Active » Needs review
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Version: 8.0.0-beta7 » 8.0.x-dev
Status: Needs review » Reviewed & tested by the community

Thank you for fixing this particular problem!!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick at Acquia commented
Status: Reviewed & tested by the community » Fixed

Nice catch. Committed and pushed to 8.0.x. Thanks!

  • webchick committed d403670 on 8.0.x 
    Issue #2452995 by Jeroen: link_path should be url in the menu API...
jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Fixed » Needs work

This needs a quick follow-up. "url" is incorrect as a word. Should be "URL".

+++ b/core/modules/system/menu.api.php
@@ -337,9 +337,9 @@
  *   - title: (required) The untranslated title of the menu link.
  *   - description: The untranslated description of the link.
  *   - route_name: (optional) The route name to be used to build the path.
- *     Either a route_name or a link_path must be provided.
+ *     Either a route_name or a url must be provided.
  *   - route_parameters: (optional) The route parameters to build the path.
- *   - link_path: (optional) If you have an external link use link_path instead
+ *   - url: (optional) If you have an external link use url instead
  *     of providing a route_name.
  *   - parent: (optional) The machine name of the link that is this link's menu
  *     parent.

Both of the changed lines need this fix.

ashutoshsngh’s picture

ashutoshsngh CreditAttribution: ashutoshsngh at Srijan | A Material+ Company commented
Status: Needs work » Needs review
FileSize
link_path_to_url-2452995-7.patch872 bytes

Changed "url" to "URL" as mentioned in #6

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs review » Needs work

Oh, my bad. So ... this text is confusing, because it is referring to array elements in text.

It should say something like "Either the route_name or url element must be provided".

JacobSanford’s picture

JacobSanford
Primary language English
Location Fredericton 🇨🇦
CreditAttribution: JacobSanford commented
Status: Needs work » Needs review
FileSize
link_path_to_url-2452995-9.patch880 bytes
interdiff_2452995_7-9.txt714 bytes

Changes as requested in #8

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs review » Needs work

OK, good. Maybe here:

+ *   - url: (optional) If you have an external link use URL instead
  *     of providing a route_name.

it should say "... use this element instead of providing route_name"?

JacobSanford’s picture

JacobSanford
Primary language English
Location Fredericton 🇨🇦
CreditAttribution: JacobSanford commented
Assigned: Unassigned » JacobSanford
Status: Needs work » Needs review
FileSize
link_path_to_url-2452995-11.patch1003 bytes
interdiff_2452995_9-11.txt816 bytes

Thanks for the review!

Enclosed are new changes as recommended in #10 and interdiff from #9.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs review » Reviewed & tested by the community

Looks good now, thanks!

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 11: link_path_to_url-2452995-11.patch, failed testing.

JacobSanford queued 11: link_path_to_url-2452995-11.patch for re-testing.

JacobSanford’s picture

JacobSanford
Primary language English
Location Fredericton 🇨🇦
CreditAttribution: JacobSanford commented
Status: Needs work » Reviewed & tested by the community

Patch tests clean again, setting to RTBTC.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed 9a668ad and pushed to 8.0.x. Thanks!

  • alexpott committed 9a668ad on 8.0.x 
    Issue #2452995 by JacobSanford, ashutoshsngh, jhodgdon: link_path should...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.