Trying to display not specified or not applicable languages with LanguageFormatter results in fatal error

This should be able to display the locked language names too, so it should indeed get all languages. Also the classic question of whether this should display at least the language code for languages which are now deleted then comes up :)

Reroll

@Berdir I see the issue needs tests, but I need more information to do this and test type.

The patch works fine, but in this patch I added some test changed, it does not work and needs more work.

Thanks @Berdir for your time.

Removing "Needs Test" tag. Already has a test.

Looks good, test works.

1. +++ b/core/modules/node/src/Tests/Views/NodeLanguageTest.php
   @@ -146,6 +157,10 @@ public function testLanguages() {
   +      // @todo Should the frontpage always display untranslatable content?
   +      if ($langcode == LanguageInterface::LANGCODE_NOT_SPECIFIED) {
   +        continue;
   

   Let's find that issue somewhere, or failing that, file it. :)

2. +++ b/core/modules/node/src/Tests/Views/NodeLanguageTest.php
   @@ -90,6 +94,13 @@ protected function setUp() {
   +    // Create non-translatable nodes.
   +    foreach ($this->nodeTitles[LanguageInterface::LANGCODE_NOT_SPECIFIED] as $index => $title) {
   +      $node = $this->drupalCreateNode(array('title' => $title, 'langcode' => LanguageInterface::LANGCODE_NOT_SPECIFIED, 'type' => 'page', 'promote' => 1));
   +      $node->body->value = $this->randomMachineName(32);
   +      $node->save();
   +    }
   

   Is the bug Views-specific? I didn't get that from the summary. If not it's strange to add the only test coverage there.

Also steps to reproduce/test would be helpful for reviewing. :)

@Berdir: well, entities have language hidden in their display formats, that can be turned on too?

Yeah #2384863: Translation language base field handler should use views field handler, provide unified options added views coverage because it was about reproducing prior views functionality. Now with the cleaned up test comments, let's see if committers are fine just basing off of that test. It certainly tests the same thing either way.

@Gábor Hojtsy yep I'm happy.

This issue addresses a major bug and is allowed per https://www.drupal.org/core/beta-changes. Committed 67692cb and pushed to 8.0.x. Thanks!

Amazing, thanks!