Parent issue: #2393329: Replace all drupal_render calls with the service, and inject it, if possible.

Problem/Motivation

drupal_render() was marked as deprecated, though its still called in quite some places.

Proposed resolution

  1. Avoid rendering manually by letting the template who is printing the variable render it.
  2. Inject the renderer service into service, which uses drupal_render()
  3. Use \Drupal::service('renderer')->render() for old prodecural code.

Remaining tasks

  1. Find all the actionable fixes: Search for drupal_render(
  2. Create a Patch
  3. Review

User interface changes

None

API changes

None

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task because this removes usages of a deprecated function.
Issue priority Not critical because the function in question is not to be removed in this release cycle.
CommentFileSizeAuthor
#1 replace_drupal_render-2472795-1.patch586 bytesmitrpaka
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mitrpaka’s picture

mitrpaka CreditAttribution: mitrpaka commented
Issue summary: View changes
FileSize
replace_drupal_render-2472795-1.patch586 bytes

\Drupal::service('renderer')->render() used for old prodecural code.

cilefen’s picture

cilefen CreditAttribution: cilefen commented
Issue summary: View changes

This looks ok to me. @mitrpaka Can you see if there is a test covering this render?

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 commented
Parent issue: #2471913: Replace drupal_render calls in core/modules/simpletest » #2393329: Replace all drupal_render calls with the service, and inject it, if possible.
xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Status: Needs review » Closed (duplicate)

Thanks for your work on this issue! Per discussion with @alexpott and @webchick, we should do these conversions in a single patch in #2393329: Replace all drupal_render calls with the service, and inject it, if possible.. The change will need to be postponed to 8.1.x at least since it is no longer an allowed change during the Drupal 8 beta. See #2393329-39: Replace all drupal_render calls with the service, and inject it, if possible..