Parent issue #2393329: Replace all drupal_render calls with the service, and inject it, if possible.

Problem/Motivation

drupal_render() was marked as deprecated, though its still called in quite some places.

Proposed resolution

  1. Avoid rendering manually by letting the template who is printing the variable render it.
  2. Inject the renderer service into service, which uses drupal_render()
  3. Use \Drupal::service('renderer')->render() for old prodecural code.

Remaining tasks

  1. Find all the actionable fixes: Search for drupal_render(
  2. Create a Patch
  3. Review

User interface changes

None

API changes

None

CommentFileSizeAuthor
#10 interdiff-aggregator_replace_drupal_render-2473161-7-10.txt445 byteskeopx
#10 aggregator_replace_drupal_render-2473161-10.patch4.93 KBkeopx
#7 interdiff-aggregator_replace_drupal_render-2473161-4-7.txt1.24 KBkeopx
#7 aggregator_replace_drupal_render-2473161-7.patch4.92 KBkeopx
#4 aggregator_replace_drupal_render-2473161-4.patch3.42 KBkeopx
#4 interduff-aggregator_replace_drupal_render-2473161-1-4.txt1.73 KBkeopx
#1 aggregator_replace_drupal_render-2473161-1.patch3.38 KBkeopx
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

keopx’s picture

keopx
Primary language Basque
Location Basque Country
CreditAttribution: keopx at Isarea commented
Assigned: keopx » Unassigned
Status: Active » Needs review
FileSize
aggregator_replace_drupal_render-2473161-1.patch3.38 KB
cilefen’s picture

cilefen CreditAttribution: cilefen commented
Status: Needs review » Needs work

The comment in #2472975-5: Replace all drupal_render calls in core/modules/ckeditor applies here.

keopx’s picture

keopx
Primary language Basque
Location Basque Country
CreditAttribution: keopx at Isarea commented
Assigned: Unassigned » keopx
keopx’s picture

keopx
Primary language Basque
Location Basque Country
CreditAttribution: keopx at Isarea commented
Assigned: keopx » Unassigned
Status: Needs work » Needs review
FileSize
interduff-aggregator_replace_drupal_render-2473161-1-4.txt1.73 KB
aggregator_replace_drupal_render-2473161-4.patch3.42 KB
Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 commented
Status: Needs review » Needs work

There are a couple of references to drupal_render() in doc blocks in AggregatorController.php.

There's also a use of drupal_render_root() in Rss.php, but that might be out of scope of this issue.

keopx’s picture

keopx
Primary language Basque
Location Basque Country
CreditAttribution: keopx at Isarea commented
Assigned: Unassigned » keopx
keopx’s picture

keopx
Primary language Basque
Location Basque Country
CreditAttribution: keopx at Isarea commented
Assigned: keopx » Unassigned
Status: Needs work » Needs review
FileSize
aggregator_replace_drupal_render-2473161-7.patch4.92 KB
interdiff-aggregator_replace_drupal_render-2473161-4-7.txt1.24 KB

Status: Needs review » Needs work

The last submitted patch, 7: aggregator_replace_drupal_render-2473161-7.patch, failed testing.

keopx’s picture

keopx
Primary language Basque
Location Basque Country
CreditAttribution: keopx at Isarea commented
Assigned: Unassigned » keopx
keopx’s picture

keopx
Primary language Basque
Location Basque Country
CreditAttribution: keopx at Isarea commented
Assigned: keopx » Unassigned
Status: Needs work » Needs review
FileSize
aggregator_replace_drupal_render-2473161-10.patch4.93 KB
interdiff-aggregator_replace_drupal_render-2473161-7-10.txt445 bytes
cilefen’s picture

cilefen CreditAttribution: cilefen commented
Status: Needs review » Needs work 
+++ b/core/modules/aggregator/src/Plugin/views/row/Rss.php
@@ -79,7 +79,7 @@ public function render($row) {
-    return drupal_render_root($build);
+    return  \Drupal::service('renderer')->renderRoot($build);

You could inject the render into RssPluginBase.

cilefen’s picture

cilefen CreditAttribution: cilefen commented
Status: Needs work » Closed (duplicate)

This is a duplicate as per #2393329-41: Replace all drupal_render calls with the service, and inject it, if possible.