Problem/Motivation
When adding multiple fields or other elements in views at once, a progress indicator is shown in the modal. This progress indicator is styled as pager, which is not correct since a user cannot page trough the fields, instead the order is fixed.
The placement of the indicator is a little out of sight and separate from the title of the added objects.
Proposed resolution
The progress indicator needs to be styled as a progress indicator instead of a pager, so we need to alter the styling. the placement in HTML needs to be altered to the correct location. I attached some mock-up's as attachments.
Remaining tasks
- agree on desired styling and placement
- alter styling
- alter php to generate progress indicator on the desired spot on the modal
User interface changes
Styling and placement of the progress indicator.
API changes
No API changes necessary.
Comment | File | Size | Author |
---|---|---|---|
#15 | 2473877-10.patch | 2.05 KB | quietone |
| |||
#10 | 2473877-10.patch | 2.05 KB | Lendude |
#10 | Screenshot 2021-03-16 at 14.30.44.png | 27.38 KB | Lendude |
progress indicator integrated with title.png | 122.87 KB | pefferen | |
progress indicator before title.png | 147.76 KB | pefferen |
Comments
Comment #1
pefferen CreditAttribution: pefferen at Triquanta commentedComment #10
LendudeWow! These suggestions are SOOOO much better than the current look. Options 2-4 are probably easier, but I love the clarity of option 1, so let's see what breaks there.
After:
Comment #14
borisson_I agree, this looks a lot better, since this is a visual change I don't think this needs tests?
Comment #15
quietone CreditAttribution: quietone at PreviousNext commentedFor whatever reason this is not retesting the patch every 2 days. Re-uploading the patch.
Comment #17
catchLooks like a really good change.
Committed/pushed to 10.1.x and cherry-picked back through to 9.5.x, thanks!
Comment #18
longwaveOpened a followup: #3295709: .views-progress-indicator CSS is unused