Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Issue #2473953 by mortendk, rteijeiro, rachel_norfolk, Cottser, LewisNyman: Prefix form-submit classes with js-
Task
Prefix form-submit classes with js- to separate classes needed for JavaScript functionality from those used for styling and make it clear which classes can safely be removed without breaking JavaScript functionality.
Remaining tasks
- Patch
- Patch review
- Manual testing
Steps to test
- Navigate to the
node/add/article
- Add an image to the upload field
- Remove the image
Beta phase evaluation
Issue category | Task |
---|---|
Issue priority | Normal |
Unfrozen changes | Unfrozen because it mostly just affects templates and JS which are not frozen. |
Prioritized changes | The main goal of this issue is to improve themer experience and arguably it reduces fragility where JavaScript and markup intersect. |
Disruption | Shouldn't be too disruptive as it is mostly affecting CSS classes that are added to markup. Themes extending Classy will only have classes added. Themes not extending Classy will have classes removed but they can be added back via template overrides. |
User interface changes
None for themes extending Classy. Possible visual changes for other themes.
API changes
n/a
Comment | File | Size | Author |
---|---|---|---|
#11 | form_submit-2.png | 155.97 KB | aburrows |
#11 | form_submit-1.png | 185.78 KB | aburrows |
#10 | prefix_form_submit-2473953-10.patch | 3.72 KB | star-szr |
#1 | 2473953-form-submit-additional.patch | 3.72 KB | star-szr |
Comments
Comment #1
star-szrInitial patch split from the parent, some additional changes from grepping, and interdiff between the two.
Comment #2
LewisNyman CreditAttribution: LewisNyman at Wunder commentedI manually tested the patch, steps in the issue summary. I also grepped for
form-submit
and couldn't find anything else to change.Comment #4
star-szrFailed because d.o was down. Thanks Lewis!
Comment #5
catchThis isn't the case. Stark ends up with both classes.
Comment #6
star-szrSure, if those classes are added in preprocess. In that case it's out of our hands unless we can and want to move the classes to templates.
Comment #7
star-szrAdding suggested commit message.
Comment #8
LewisNyman CreditAttribution: LewisNyman at Wunder commentedMakes sense to me
Comment #9
alexpottWhich patch is rtbc?
Comment #10
star-szrRe-uploading the relevant patch.
Comment #11
aburrows CreditAttribution: aburrows as a volunteer commentedTested patch and works as intended
Comment #12
alexpottCommitted d8442c8 and pushed to 8.0.x. Thanks!
Thanks for adding the beta evaluation to the issue summary.