Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
Lets reduce the reliance on text that starts with "If, When" this is bad practice according to our UI standards.
Proposed resolution
Remaining tasks
Before
After
User interface changes
API changes
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | after-apply-patch.png | 63.05 KB | Manjit.Singh |
| #11 | before-apply-patch.png | 67.04 KB | Manjit.Singh |
| #8 | exposedoptionreduction-8.patch | 3.32 KB | yogen.prasad |
| #4 | Views_Exposed_option.png | 27.78 KB | manauwarsheikh |
| #4 | core-exposedoptions-enhancement-4.patch | 3.64 MB | manauwarsheikh |
Comments
Comment #1
Bojhan CreditAttribution: Bojhan as a volunteer commentedComment #2
nateB CreditAttribution: nateB as a volunteer commentedEvaluating as part of DrupalCon LA Friday sprint.
I agree that this can be improved!
It's somewhat obvious for those experienced with Drupal Views, but maybe worth mentioning for others who come along that this is found in a View, e.g. Frontpage (found at /admin/structure/views/view/frontpage) under Pager options (assuming pagination is enabled).
BTW this is the Exposed Options checkbox array after applying this patch in its default state:
I think a few wording changes could improve this more:
- "Allow users to control options of the shown view."
+ "Allow user to control selected display options for this view."
- "Control the number of items in a view"
+ "Allow user to control the number of items displayed in this view"
- "Option to show all items"
+ "Allow user to to display all items"
- "Control the offset in a view"
+ "Allow user to control offset in this view" OR
+ "Allow user to specify number of items skipped from beginning of this view." – if defining what "offset" means could benefit the admin.
Whaddya think?
Comment #3
manauwarsheikh CreditAttribution: manauwarsheikh commentedReviewed.
The Initial set of requirements is fine.I will commit patch for latest requirements.
attached screenshot
Comment #4
manauwarsheikh CreditAttribution: manauwarsheikh commentedI have changed the views exposed option,as suggested in last comment.
Comment #7
yogen.prasad CreditAttribution: yogen.prasad commentedComment #8
yogen.prasad CreditAttribution: yogen.prasad commentedCreated patch with changes mentioned in #2
Comment #9
yogen.prasad CreditAttribution: yogen.prasad commentedComment #10
yogen.prasad CreditAttribution: yogen.prasad commentedComment #11
Manjit.SinghThanks Yogendra for worked on this, Changes looks good to me.
RTBC+ :)
Comment #12
alexpottCommitted 5680ad0 and pushed to 8.0.x. Thanks!
UI test is not yet frozen in beta.